Change in vdsm[master]: BZ#726960 - Recognise faulty domains on deactivateSD.

Saggi Mizrahi smizrahi at redhat.com
Wed Aug 3 15:04:09 UTC 2011


Saggi Mizrahi has posted comments on this change.

Change subject: BZ#726960 - Recognise faulty domains on deactivateSD.
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/storage/sp.py
Line 784:             dom.validate(False) #Check the domain WITHOUT cache
In comments, don't describe WHAT you do but WHY are you doing it.

--
To view, visit http://gerrit.usersys.redhat.com/783
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0a967d21bbbcbcdd91baa2a8f6aa53c4ca7ad2e4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo Warszawski <ewarszaw at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list