Change in vdsm[master]: BZ#725240 logrotate libvirtd.log often

Yotam Oron yoron at redhat.com
Tue Aug 2 11:56:09 UTC 2011


Yotam Oron has posted comments on this change.

Change subject: BZ#725240 logrotate libvirtd.log often
......................................................................


Patch Set 3: Looks good to me, but someone else must approve

(1 inline comment)

....................................................
File vdsm.spec.in
Line 163:         /bin/sed -i -e "/# vdsm/,/# end vdsm/d" $tmp_sudoers /etc/logrotate.d/libvirtd
I guess it is not for this patch, but the adding data to a file in one place and deleting the data in a totally different place will one day come back and bite us in the butt.
We should unite it to a single file that can be called with different arguments ('install', 'remove' etc)

--
To view, visit http://gerrit.usersys.redhat.com/773
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a702e6f54a2c950f850096bdd36949e5947a8fd
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Yotam Oron <yoron at redhat.com>


More information about the vdsm-patches mailing list