Change in vdsm[master]: Change getChain() to return dictionary with chain itself and...

Eduardo Warszawski ewarszaw at redhat.com
Mon Aug 1 15:34:28 UTC 2011


Eduardo Warszawski has posted comments on this change.

Change subject: Change getChain() to return dictionary with chain itself and its template.
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(2 inline comments)

....................................................
File vdsm/storage/image.py
Line 307:         """
Update doc.

Line 310:         chainDict = {'chain':[], 'template':None}
This is a dict, no need to remark it in the name.
Why a dict?
Most use cases need the template also.
IMHO is better to return the whole chain as an ordered list.
Consumer can do with the template the right thing.
Please consider receive/return volumes instead of UUIDs in order to avoid to re-produce many times the volumes.

--
To view, visit http://gerrit.usersys.redhat.com/692
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ife46d592171aedea087e0d6462b735cd7e0d75e0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: David Naori <dnaori at redhat.com>
Gerrit-Reviewer: Eduardo Warszawski <ewarszaw at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list