Change in vdsm[master]: BZ#726630 Use only os.access to check permissions

danken at redhat.com danken at redhat.com
Mon Aug 1 14:43:35 UTC 2011


Dan Kenigsberg has submitted this change and it was merged.

Change subject: BZ#726630 Use only os.access to check permissions
......................................................................


BZ#726630 Use only os.access to check permissions

The old implementation of fileUtils.pathExists was using a flawed
re-implementation of os.access as backup check for files with a NFS
stale handle, the consequence was that accessible files were
reported as non-accessible.
We now use os.stat to refresh the NFS handle and then os.access to
determine weather we can read and write the file.

Change-Id: Ic7b892886416e866178ac88c04cbfb68ed0c055b
---
M vdsm/storage/fileUtils.py
1 file changed, 9 insertions(+), 13 deletions(-)

Approvals:
  Dan Kenigsberg: Looks good to me, approved
  Jakub Libosvar: Verified


--
To view, visit http://gerrit.usersys.redhat.com/733
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic7b892886416e866178ac88c04cbfb68ed0c055b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Jakub Libosvar <libosvar at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list