Change in vdsm[master]: BZ#726970 BZ#717868: iscsiadm better error handling

David Naori dnaori at redhat.com
Mon Aug 1 07:29:56 UTC 2011


David Naori has posted comments on this change.

Change subject: BZ#726970 BZ#717868: iscsiadm better error handling
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File vdsm/storage/storage_exception.py
Line 844: class iSCSILoginAuthError(StorageServeriSCSIError):
This exception was not used at all. i just used that free unused code=460 to add AuthError.

The general exception for iscsi login failure is iSCSILoginError (464) and i wanted it to be raised in case: 
 5      ISCSI_ERR_LOGIN - generic iSCSI login failure.
 19     ISCSI_ERR_FATAL_LOGIN - fatal iSCSI login error.

and according to the man page those and the already exist are the only login errors.

--
To view, visit http://gerrit.usersys.redhat.com/770
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I67c8fc5430dd548877b26c802bcd3b3e775a20fe
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: David Naori <dnaori at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: David Naori <dnaori at redhat.com>


More information about the vdsm-patches mailing list