<html>
<head>
<meta http-equiv="content-type" content="text/html; charset=ISO-8859-1">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Hi,<br>
<br>
I submited a patch for text-based console
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
<a href="http://gerrit.ovirt.org/#/c/7165/">http://gerrit.ovirt.org/#/c/7165/</a><br>
<br>
the issue I want to discussing as below:<br>
1. fix port VS dynamic port<br>
<p style="margin-top: 0px; padding-top: 0.5em; color: rgb(0, 0, 0);
font-family: 'Lucida Console', 'Lucida Sans Typewriter', Monaco,
monospace; font-size: 11px; font-style: normal; font-variant:
normal; font-weight: normal; letter-spacing: normal; line-height:
normal; orphans: 2; text-align: -webkit-left; text-indent: 0px;
text-transform: none; white-space: pre; widows: 2; word-spacing:
0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width:
0px; background-color: rgb(252, 254, 239); ">Use fix port for all
VM's console. connect console with 'ssh vmUUID@ip -p port'.<br>
Distinguishing VM by vmUUID.</p>
<br>
The current implement was vdsm will allocated port for console
dynamically and spawn sub-process when VM creating. <br>
In sub-process the main thread responsible for accept new connection
and dispatch output of console to each connection.<br>
When new connection is coming, main processing create new thread for
each new connection. Dynamic port will allocated<br>
port for each VM and use range port. It isn't good for firewall
rules.<br>
<br>
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
<br>
so I got a suggestion that use fix port. and connect console with
'ssh vmuuid@hostip -p fixport'. this is simple for user.<br>
We need one process for accept new connection from fix port and when
new connection is coming, spawn sub-process for each vm.<br>
But because the console only can open by one process, main process
need responsible for dispatching console's output of all vms and all
connection.<br>
So the code will be a little complex then dynamic port.<br>
<br>
So this is dynamic port VS fix port and simple code VS complex
code.<br>
<br>
Thanks!<br>
<br>
<br>
</body>
</html>