[vdsm] pylint in make check-local

Dan Kenigsberg danken at redhat.com
Wed Feb 12 22:25:57 UTC 2014


Recently, we've had a bugs
    http://gerrit.ovirt.org/#/c/24242/
that could have been avoided had we used pylint to check our code before
its usage. Two other bugs-in-waiting can be quickly removed
    http://gerrit.ovirt.org/#/c/24313/
    http://gerrit.ovirt.org/#/c/24412/

I would like to suggest
    http://gerrit.ovirt.org/#/c/24382/
    "make check: add a pylint check"

We have a long way to go before pylint is happy with our code, but I
believe that pylinting some of our modules is a good start.

The down sides are many: it's slow, it's another dependency, it has
false negatives, and I do not yet understand how it behaves
(particularly, the interdependency between checked modules).

What do you think? Should we add it?

Regards,
Dan.


More information about the vdsm-devel mailing list