[vdsm] broken test FileVolumeGetVSizeTest in git master

Giuseppe Vallarelli gvallare at redhat.com
Tue Aug 6 09:00:58 UTC 2013


----- Original Message -----
| From: "Antoni Segura Puimedon" <asegurap at redhat.com>
| To: "VDSM Project Development" <vdsm-devel at lists.fedorahosted.org>
| Sent: Monday, August 5, 2013 7:06:00 PM
| Subject: [vdsm] broken test FileVolumeGetVSizeTest in git master
| 
| Hi oVirters,
| 
| Apparently due to commit:
| 
|     commit a3b4b2cb6ee0ea8dbe04413882d52d8a0e776ef8
|     Author: Eduardo Warszawski <ewarszaw at redhat.com>
|     Date:   Wed Jul 31 04:49:52 2013 +0300
| 
|         Avoid Img and Vol produces in fileVolume.getV*Size
| 
|     No need for produce Images and Volumes for get the volume path
|     when calculating the size.
|     
|     Related to BZ#960952, BZ#769502.
| 
| which adds the line:
| 
|     volPath = os.path.join(sdobj.mountpoint, sdobj.sdUUID, 'images',
| 
| the test in $subj, FileVolumeGetVSizeTest is broken, since it calls:
| 
|     volSize = FileVolume.getVSize(self.sdobj, self.imgUUID, self.volUUID)
| 
| that uses FileDomainMockObject (which does not have a mountpoint), resulting
| in
| 
|    AttributeError: 'FileDomainMockObject' object has no attribute
|    'mountpoint'
| 
| Best regards,
| 
| Toni


I've submitted a patch for it http://gerrit.ovirt.org/#/c/17705/1

Giuseppe


| _______________________________________________
| vdsm-devel mailing list
| vdsm-devel at lists.fedorahosted.org
| https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel
| 


More information about the vdsm-devel mailing list