[vdsm] a problem with pepe8

Dan Kenigsberg danken at redhat.com
Fri May 18 13:58:50 UTC 2012


On Fri, May 18, 2012 at 09:47:43PM +0800, ShaoHe Feng wrote:
> On 05/18/2012 08:30 PM, Dan Kenigsberg wrote:
> >On Fri, May 18, 2012 at 06:57:10AM -0500, Adam Litke wrote:
> >>On Fri, May 18, 2012 at 03:56:05PM +0800, ShaoHe Feng wrote:
> >>>a comment exceed 80 characters,  and it is a url link.
> >>>such as
> >>># http://aaaaaaaaaaaa/bbbbbbbbbbbbbb/cccccccccccc/dddddddddddd/eeeeeeeeeeeeeee/fffffffffffffffffff/
> >>>
> >>>how can I do?
> >>>is this OK?
> >>># "http:/aaaaaaaaaaaa/bbbbbbbbbbbbbb/cccccccccccc/
> >>># dddddddddddd/eeeeeeeeeeeeeee/fffffffffffffffffff/"
> >>># (the link is too long to fit in one line, copy it and paste it to
> >>>one line)
> >>It would be nice if we could annotate the source code to disable certain checks
> >>in places such as this.  Clearly the rigid line length restriction would result
> >>in a less readable comment if followed here.
> >Agreed. PEP-0008 is here to help us. If the script that enforces it is
> >actually hurts readability in a certain case, we should not use it.
> >
> >Please fix other PEP-0008 issues in the file, and try to filter out the
> >url warning. If impossible, the module would not be whitelisted.
> >
> yes, pep8 has a option "--ignore=errors", but if this option is
> given when all the same type errors will be ignored.

Hey, it is opensource. You can hack it to ignore specific error (and
push upstream, and wait until it's in Fedora), or you can `grep -v` its
output.
can grep the output
> 
> 


More information about the vdsm-devel mailing list