[vdsm] gerrit problem when reviewing VDSM code

Itamar Heim iheim at redhat.com
Tue May 8 06:25:33 UTC 2012


On 05/08/2012 08:24 AM, Itamar Heim wrote:
> On 05/08/2012 04:50 AM, Shu Ming wrote:
>> Hi,
>> In my reviewing patches in gerrit for VDSM code, I found it was a bit
>> awkward to understand the diffs without much context above or below the
>> diffs. I hope I can read the unchanged lines around the diffs to get
>> more information. The unchanged lines should be in folding state when I
>> don't care about them and can be unfolded when I need more information.
>> What do you think about this?
>>
>
> just changed in gerrit the context to show you 'whole file' rather than
> '10 lines'?

this should have read "just change...", it is a user level change.

> _______________________________________________
> vdsm-devel mailing list
> vdsm-devel at lists.fedorahosted.org
> https://fedorahosted.org/mailman/listinfo/vdsm-devel



More information about the vdsm-devel mailing list