[vdsm] gerrit problem when reviewing VDSM code

Itamar Heim iheim at redhat.com
Tue May 8 06:23:25 UTC 2012


On 05/08/2012 09:03 AM, Shu Ming wrote:
> On 2012-5-8 13:24, Itamar Heim wrote:
>> On 05/08/2012 04:50 AM, Shu Ming wrote:
>>> Hi,
>>> In my reviewing patches in gerrit for VDSM code, I found it was a bit
>>> awkward to understand the diffs without much context above or below the
>>> diffs. I hope I can read the unchanged lines around the diffs to get
>>> more information. The unchanged lines should be in folding state when I
>>> don't care about them and can be unfolded when I need more information.
>>> What do you think about this?
>>>
>>
>> just changed in gerrit the context to show you 'whole file' rather
>> than '10 lines'?
>>
> Yes. 10 lines don't have much meaning to the people not familiar with
> the file, but still have an interesting to review the code. More context
> will help them to review the code without patching the diffs into the
> original file.
>

sorry if i wasn't clear - the change is something you can do when 
viewing the patch, not a general change.



More information about the vdsm-devel mailing list