<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<br>
<div class="moz-cite-prefix">On 07/09/2015 11:15 AM, Pavel Reichl
wrote:<br>
</div>
<blockquote cite="mid:559E3BC9.8010300@redhat.com" type="cite">
<meta http-equiv="content-type" content="text/html; charset=utf-8">
Hello,<br>
<br>
please see attached patches.<br>
<br>
1st patch adds return value ENOENT to sss_iface_addr_list_get() so
I can provide more concrete debug message for missing interface or
if interface is not suitable (missing IP address)<br>
<br>
2nd patch:<br>
* I introduced new public function sss_iface_addr_concatenate(),
I'm aware that this function is probably not reusable but I needed
to work around that 'struct sss_iface_addr' in defined in source
file only.<br>
* I had troubles with correctly handling creating talloc hiearchy
of IPs of different interfaces. I decided to use first address of
first found interface as a parent talloc context for other
interfaces. I attached talloc report output to illustrate this.<br>
<blockquote type="cite">
<ol>
<li>
<div style="font: normal normal 1em/1.2em monospace;
margin:0; padding:0; background:none; vertical-align:top;">full
talloc report on 'struct sdap_dyndns_get_addrs_state'
(total 16 bytes in 1 blocks)</div>
</li>
<li>
<div style="font: normal normal 1em/1.2em monospace;
margin:0; padding:0; background:none; vertical-align:top;">full
talloc report on 'struct sdap_dyndns_get_addrs_state'
(total 376 bytes in 19 blocks)</div>
</li>
<li>
<div style="font: normal normal 1em/1.2em monospace;
margin:0; padding:0; background:none; vertical-align:top;">
struct sss_iface_addr contains 360 bytes in
18 blocks (ref 0) 0xbc0650</div>
</li>
<li>
<div style="font: normal normal 1em/1.2em monospace;
margin:0; padding:0; background:none; vertical-align:top;">
struct sss_iface_addr contains 120 bytes
in 6 blocks (ref 0) 0xbecee0</div>
</li>
<li>
<div style="font: normal normal 1em/1.2em monospace;
margin:0; padding:0; background:none; vertical-align:top;">
struct sss_iface_addr contains 80
bytes in 4 blocks (ref 0) 0xbeb920</div>
</li>
<li>
<div style="font: normal normal 1em/1.2em monospace;
margin:0; padding:0; background:none; vertical-align:top;">
struct sss_iface_addr contains
40 bytes in 2 blocks (ref 0) 0xbd03f0</div>
</li>
<li>
<div style="font: normal normal 1em/1.2em monospace;
margin:0; padding:0; background:none; vertical-align:top;">
../src/providers/dp_dyndns.c:219
contains 16 bytes in 1 blocks (ref 0) 0xbd0470</div>
</li>
<li>
<div style="font: normal normal 1em/1.2em monospace;
margin:0; padding:0; background:none; vertical-align:top;">
../src/providers/dp_dyndns.c:219 contains
16 bytes in 1 blocks (ref 0) 0xbeb9a0</div>
</li>
<li>
<div style="font: normal normal 1em/1.2em monospace;
margin:0; padding:0; background:none; vertical-align:top;">
../src/providers/dp_dyndns.c:219 contains 16
bytes in 1 blocks (ref 0) 0xbecf60</div>
</li>
<li>
<div style="font: normal normal 1em/1.2em monospace;
margin:0; padding:0; background:none; vertical-align:top;">
struct sss_iface_addr contains 120 bytes
in 6 blocks (ref 0) 0xbd0640</div>
</li>
<li>
<div style="font: normal normal 1em/1.2em monospace;
margin:0; padding:0; background:none; vertical-align:top;">
struct sss_iface_addr contains 80
bytes in 4 blocks (ref 0) 0xbd19a0</div>
</li>
<li>
<div style="font: normal normal 1em/1.2em monospace;
margin:0; padding:0; background:none; vertical-align:top;">
struct sss_iface_addr contains
40 bytes in 2 blocks (ref 0) 0xbcfb00</div>
</li>
<li>
<div style="font: normal normal 1em/1.2em monospace;
margin:0; padding:0; background:none; vertical-align:top;">
../src/providers/dp_dyndns.c:219
contains 16 bytes in 1 blocks (ref 0) 0xbed300</div>
</li>
<li>
<div style="font: normal normal 1em/1.2em monospace;
margin:0; padding:0; background:none; vertical-align:top;">
../src/providers/dp_dyndns.c:219 contains
16 bytes in 1 blocks (ref 0) 0xbd1a20</div>
</li>
<li>
<div style="font: normal normal 1em/1.2em monospace;
margin:0; padding:0; background:none; vertical-align:top;">
../src/providers/dp_dyndns.c:219 contains 16
bytes in 1 blocks (ref 0) 0xbd06c0</div>
</li>
<li>
<div style="font: normal normal 1em/1.2em monospace;
margin:0; padding:0; background:none; vertical-align:top;">
struct sss_iface_addr contains 80 bytes
in 4 blocks (ref 0) 0xbd0eb0</div>
</li>
<li>
<div style="font: normal normal 1em/1.2em monospace;
margin:0; padding:0; background:none; vertical-align:top;">
struct sss_iface_addr contains 40
bytes in 2 blocks (ref 0) 0xbd1900</div>
</li>
<li>
<div style="font: normal normal 1em/1.2em monospace;
margin:0; padding:0; background:none; vertical-align:top;">
../src/providers/dp_dyndns.c:219 contains
16 bytes in 1 blocks (ref 0) 0xbec4f0</div>
</li>
<li>
<div style="font: normal normal 1em/1.2em monospace;
margin:0; padding:0; background:none; vertical-align:top;">
../src/providers/dp_dyndns.c:219 contains 16
bytes in 1 blocks (ref 0) 0xbeca10</div>
</li>
<li>
<div style="font: normal normal 1em/1.2em monospace;
margin:0; padding:0; background:none; vertical-align:top;">
../src/providers/dp_dyndns.c:219 contains 16
bytes in 1 blocks (ref 0) 0xbe6ae0</div>
</li>
</ol>
</blockquote>
* I was thinking whether it would be a good idea to handle the
case when processing of interfaces provided in dyndns_iface yields
no address at all by continuing to detect DYNDNS address from LDAP
connection?<br>
<br>
Thanks!<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
sssd-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:sssd-devel@lists.fedorahosted.org">sssd-devel@lists.fedorahosted.org</a>
<a class="moz-txt-link-freetext" href="https://lists.fedorahosted.org/mailman/listinfo/sssd-devel">https://lists.fedorahosted.org/mailman/listinfo/sssd-devel</a>
</pre>
</blockquote>
While reading #2558 I noticed that there is a further request
relating to these patches - mbasti asks If there could be some mean
how to send IPs of all interfaces?
<br>
Is this a good idea in general?<br>
I suppose I could implement it with some special value for
'dyndns_iface' - ideally the special value would contain characters
prohibited to be part of interface name if there are such...<br>
</body>
</html>