<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
On 04/01/2015 08:51 AM, Lukas Slebodnik wrote:<br>
<blockquote cite="mid:20150401065127.GB30096@mail.corp.redhat.com"
type="cite">
<div class="moz-text-plain" wrap="true" graphical-quote="true"
style="font-family: -moz-fixed; font-size: 12px;"
lang="x-unicode">
<pre wrap="">ehlo,
simple patch is attached.
It fixes warning from clang static analyzer.
LS
</pre>
</div>
<br>
</blockquote>
Patch LGTM, but I think there is a typo.<br>
<blockquote cite="mid:20150401065127.GB30096@mail.corp.redhat.com"
type="cite">
<fieldset class="mimeAttachmentHeader"><legend
class="mimeAttachmentHeaderName">0001-GPO-Check-return-value-of-ad_gpo_store_policy_settin.patch</legend></fieldset>
<br>
<div class="moz-text-plain" wrap="true" graphical-quote="true"
style="font-family: -moz-fixed; font-size: 12px;"
lang="x-unicode">
<pre wrap="">From 80206c522c25d87bf7592259fe7d7d6ed6835470 Mon Sep 17 00:00:00 2001
From: Lukas Slebodnik <a moz-do-not-send="true" class="moz-txt-link-rfc2396E" href="mailto:lslebodn@redhat.com"><lslebodn@redhat.com></a>
Date: Fri, 6 Mar 2015 20:42:35 +0100
Subject: [PATCH] GPO: Check return value of ad_gpo_store_policy_settings
---
src/providers/ad/ad_gpo.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/src/providers/ad/ad_gpo.c b/src/providers/ad/ad_gpo.c
index a9879b41b6b618d4c73156d95378c9bcd2b397c4..8caea392ac778e81704a9742587a89d1bbfefaf1 100644
--- a/src/providers/ad/ad_gpo.c
+++ b/src/providers/ad/ad_gpo.c
@@ -2181,6 +2181,12 @@ ad_gpo_cse_done(struct tevent_req *subreq)
*/
ret = ad_gpo_store_policy_settings(state->domain,
cse_filtered_gpo->policy_filename);
+ if (ret != EOK) {
+ DEBUG(SSSDBG_OP_FAILURE,
+ "ad_gpo_store_policy_settings failed: [%d](%s}\n",</pre>
</div>
</blockquote>
typo - 's/}/)' ?
<br>
<blockquote cite="mid:20150401065127.GB30096@mail.corp.redhat.com"
type="cite">
<div class="moz-text-plain" wrap="true" graphical-quote="true"
style="font-family: -moz-fixed; font-size: 12px;"
lang="x-unicode">
<pre wrap="">
+ ret, sss_strerror(ret));
+ goto done;
+ }
state->cse_gpo_index++;
ret = ad_gpo_cse_step(req);
<div class="moz-txt-sig">--
2.3.4
</div></pre>
</div>
</blockquote>
<br>
</body>
</html>