<html>
  <head>
    <meta content="text/html; charset=utf-8" http-equiv="Content-Type">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    <br>
    <br>
    <div class="moz-cite-prefix">On 03/20/2015 11:36 AM, Pavel Reichl
      wrote:<br>
    </div>
    <blockquote cite="mid:550BF826.7080800@redhat.com" type="cite">
      <blockquote type="cite">On Thu, Mar 19, 2015 at 03:18:11PM +0100,
        Pavel Reichl wrote:
        <br>
        <blockquote type="cite">On 03/10/2015 03:43 PM, Sumit Bose
          wrote:
          <br>
          <blockquote type="cite">@@ -1982,6 +1986,36 @@ static void
            sdap_get_groups_process(struct tevent_req *subreq)
            <br>
                      return;
            <br>
                  }
            <br>
            +    if (state-&gt;no_members) {
            <br>
            +        ret =
            sysdb_attrs_primary_name_list(state-&gt;sysdb, state,
            <br>
            +                                state-&gt;groups,
            state-&gt;count,
            <br>
            +                               
            state-&gt;opts-&gt;group_map[SDAP_AT_GROUP_NAME].name,
            <br>
            +                                &amp;groupnamelist);
            <br>
            +        if (ret != EOK) {
            <br>
            +            DEBUG(SSSDBG_OP_FAILURE,
            <br>
            +                  "sysdb_attrs_primary_name_list
            failed.\n");
            <br>
            +            tevent_req_error(req, ret);
            <br>
            +            return;
            <br>
            +        }
            <br>
            +
            <br>
            +        ret = sdap_add_incomplete_groups(state-&gt;sysdb,
            state-&gt;dom, state-&gt;opts,
            <br>
            +                                         groupnamelist,
            state-&gt;groups,
            <br>
            +                                         state-&gt;count);
            <br>
            +        if (ret == EOK) {
            <br>
            +            DEBUG(SSSDBG_TRACE_LIBS,
            <br>
            +                  "Reading only group data without members
            successful.\n");
            <br>
            +            tevent_req_done(req);
            <br>
            +        } else {
            <br>
            +            DEBUG(SSSDBG_OP_FAILURE,
            "sdap_add_incomplete_groups failed.\n");
            <br>
            +            tevent_req_error(req, ret);
            <br>
            +        }
            <br>
            +        return;
            <br>
          </blockquote>
          unused code starts here
          <br>
          <blockquote type="cite">+
            <br>
            +        ret = sdap_save_groups(state, state-&gt;sysdb,
            state-&gt;dom, state-&gt;opts,
            <br>
            +                               state-&gt;groups,
            state-&gt;count, false,
            <br>
            +                               NULL, true, NULL);
            <br>
            +    }
            <br>
            +
            <br>
          </blockquote>
          Hello,
          <br>
          <br>
          coverity found this unused code - is it OK to just remove
          sdap_save_groups()
          <br>
        </blockquote>
        yes, please remove it. While you are at it I wonder if you can
        fix the
        <br>
        debug message (s/Reading/Writing/) above as well?
        <br>
        <br>
        bye,
        <br>
        Sumit
        <br>
        <br>
      </blockquote>
      Please see this trivial patch.
      <br>
      <br>
      Thanks!
      <br>
      <br>
      <fieldset class="mimeAttachmentHeader"></fieldset>
      <br>
      <pre wrap="">_______________________________________________
sssd-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:sssd-devel@lists.fedorahosted.org">sssd-devel@lists.fedorahosted.org</a>
<a class="moz-txt-link-freetext" href="https://lists.fedorahosted.org/mailman/listinfo/sssd-devel">https://lists.fedorahosted.org/mailman/listinfo/sssd-devel</a>
</pre>
    </blockquote>
    ci passed:<br>
    <pre wrap=""><a class="moz-txt-link-freetext" href="http://sssd-ci.duckdns.org/logs/job/11/23/summary.html">http://sssd-ci.duckdns.org/logs/job/11/23/summary.html</a></pre>
    <br>
  </body>
</html>