<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<br>
<br>
<div class="moz-cite-prefix">On 03/19/2015 02:31 PM, Sumit Bose
wrote:<br>
</div>
<blockquote cite="mid:20150319133159.GD27609@p.redhat.com"
type="cite">
<pre wrap="">Hi,
Steeve found another issue while testing with older FreeIPA server
versions. This patch should fix it.
bye,
Sumit
</pre>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
sssd-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:sssd-devel@lists.fedorahosted.org">sssd-devel@lists.fedorahosted.org</a>
<a class="moz-txt-link-freetext" href="https://lists.fedorahosted.org/mailman/listinfo/sssd-devel">https://lists.fedorahosted.org/mailman/listinfo/sssd-devel</a>
</pre>
</blockquote>
<br>
Thanks, LGTM. ci passed - <br>
<pre wrap=""><a class="moz-txt-link-freetext" href="http://sssd-ci.duckdns.org/logs/job/11/14/summary.html">http://sssd-ci.duckdns.org/logs/job/11/14/summary.html</a></pre>
<br>
I have just one question related to your patch - please see snippet
from the same function:<br>
<blockquote type="cite"> for (c = 0; members[c] != NULL; c++) {<br>
obj_domain = find_domain_by_object_name(parent_domain,
members[c]);<br>
if (obj_domain == NULL) {<br>
DEBUG(SSSDBG_OP_FAILURE, "find_domain_by_object_name
failed.\n");<br>
ret = ENOMEM;<br>
goto done;<br>
}<br>
<br>
ret = sysdb_search_user_by_name(tmp_ctx, obj_domain,
members[c], NULL,<br>
&msg);<br>
if (ret == EOK) {<br>
if (group_attrs != NULL) {<br>
dn_str = ldb_dn_get_linearized(msg->dn);<br>
if (dn_str == NULL) {<br>
DEBUG(SSSDBG_OP_FAILURE,
"ldb_dn_get_linearized failed.\n");<br>
</blockquote>
Should we set 'ret' here to some errorcode or set '_missing_members'
same way you did in your patch?<br>
<br>
Thanks!<br>
<br>
<blockquote type="cite">
goto done;<br>
}<br>
<br>
DEBUG(SSSDBG_TRACE_ALL, "Adding member
[%s][%s]\n",<br>
members[c], dn_str);<br>
</blockquote>
<br>
<br>
</body>
</html>