<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<br>
<div class="moz-cite-prefix">On 02/27/2015 04:54 PM, Lukas Slebodnik
wrote:<br>
</div>
<blockquote cite="mid:20150227155458.GE10731@mail.corp.redhat.com"
type="cite">
<pre wrap="">On (25/02/15 19:19), Pavel Reichl wrote:
</pre>
<blockquote type="cite">
<pre wrap="">
On 02/25/2015 05:43 PM, Lukas Slebodnik wrote:
</pre>
<blockquote type="cite">
<pre wrap="">ehlo,
attached patch should fix PavelR's issue with make install
LS
</pre>
</blockquote>
<pre wrap="">Thanks. It indeed fixes my problem. Code looks good to me.
Only nitpick I noticed is that calling make uninstall twice fails, as there
are no file to be unlinked.
Would you consider amending the patch?
diff --git a/Makefile.am b/Makefile.am
index 096d422..88a8720 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -3192,17 +3192,17 @@ uninstall-hook:
done;
if BUILD_PYTHON2_BINDINGS
cd $(DESTDIR)$(py2execdir) && \
- unlink pysss.so ; \
- unlink pyhbac.so ; \
- unlink pysss_murmur.so ; \
- unlink pysss_nss_idmap.so
+ [ ! -e pysss.so ] || unlink pysss.so ; \
+ [ ! -e pyhbac.so ] || unlink pyhbac.so ; \
+ [ ! -e pysss_murmur.so ] || unlink pysss_murmur.so ; \
+ [ ! -e pysss_nss_idmap.so ] || unlink pysss_nss_idmap.so
endif
if BUILD_PYTHON3_BINDINGS
cd $(DESTDIR)$(py3execdir) && \
- unlink pysss.so ; \
- unlink pyhbac.so ; \
- unlink pysss_murmur.so ; \
- unlink pysss_nss_idmap.so
+ [ ! -e pysss.so ] || unlink pysss.so ; \
+ [ ! -e pyhbac.so ] || unlink pyhbac.so ; \
+ [ ! -e pysss_murmur.so ] || unlink pysss_murmur.so ; \
+ [ ! -e pysss_nss_idmap.so ] || unlink pysss_nss_idmap.so
</pre>
</blockquote>
<pre wrap="">I'm sorry but that's ugly.</pre>
</blockquote>
I've never claimed I have a good taste. :-)<br>
<blockquote cite="mid:20150227155458.GE10731@mail.corp.redhat.com"
type="cite">
<pre wrap="">
I consulted it with our POSIX expert and it is safe to use "rm -f" for removing
symbolic links.</pre>
</blockquote>
Works for me. Thanks!<br>
ci: <a class="moz-txt-link-freetext"
href="http://sssd-ci.duckdns.org/logs/job/8/47/summary.html">http://sssd-ci.duckdns.org/logs/job/8/47/summary.html</a><br>
<br>
ACK<br>
<blockquote cite="mid:20150227155458.GE10731@mail.corp.redhat.com"
type="cite">
<pre wrap="">
Updated version is attached.
LS
</pre>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
sssd-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:sssd-devel@lists.fedorahosted.org">sssd-devel@lists.fedorahosted.org</a>
<a class="moz-txt-link-freetext" href="https://lists.fedorahosted.org/mailman/listinfo/sssd-devel">https://lists.fedorahosted.org/mailman/listinfo/sssd-devel</a>
</pre>
</blockquote>
<br>
</body>
</html>