<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<br>
<div class="moz-cite-prefix">On 12/02/2014 12:50 PM, Lukas Slebodnik
wrote:<br>
</div>
<blockquote cite="mid:20141202115030.GC24292@mail.corp.redhat.com"
type="cite">
<pre wrap="">On (29/10/14 17:17), Pavel Reichl wrote:
</pre>
<blockquote type="cite">
<pre wrap="">Hello,
please see attached patch.
This patch is part of solution for
<a class="moz-txt-link-freetext" href="https://fedorahosted.org/sssd/ticket/1991">https://fedorahosted.org/sssd/ticket/1991</a>
which aims to unify return values of sysdb calls in case no results are
found.
</pre>
</blockquote>
<pre wrap="">a) this patch cannot be applied on current master.
b) I wrote similar patch becuse sssd_be crashed in function
get_object_from_cache. sysdb_search_object_by_sid didn' returned ENOENT and
res->msgs was NULL (result: dereference of NULL pointer)
-- it is yet another result of broken IPA <-> AD trust
c) Could you compare your version and mine?
Feel free to include my patch to yours if it is not good enogh.
d) test test_sysdb_delete_by_sid seems to be unrelated to this patch.
I would prefer to have it in separete patch.
LS
</pre>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
sssd-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:sssd-devel@lists.fedorahosted.org">sssd-devel@lists.fedorahosted.org</a>
<a class="moz-txt-link-freetext" href="https://lists.fedorahosted.org/mailman/listinfo/sssd-devel">https://lists.fedorahosted.org/mailman/listinfo/sssd-devel</a>
</pre>
</blockquote>
Please send you patch in new thread and then I'll rebase my patches
on top of it.<br>
Please also fix commit message. <br>
<br>
Thanks!<br>
</body>
</html>