<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<br>
<div class="moz-cite-prefix">On 11/24/2014 10:43 PM, Michal Židek
wrote:<br>
</div>
<blockquote cite="mid:5473A687.6060508@redhat.com" type="cite">On
11/24/2014 10:08 PM, Lukas Slebodnik wrote:
<br>
<blockquote type="cite">On (24/11/14 19:29), Jakub Hrozek wrote:
<br>
<blockquote type="cite">On Mon, Nov 24, 2014 at 06:37:04PM
+0100, Lukas Slebodnik wrote:
<br>
<blockquote type="cite">On (24/11/14 17:21), Michal Židek
wrote:
<br>
<blockquote type="cite">On 11/24/2014 11:16 AM, Pavel Reichl
wrote:
<br>
<blockquote type="cite">Hello Michal, please see my
comment inline.
<br>
<br>
On 11/21/2014 10:34 PM, Michal Židek wrote:
<br>
<blockquote type="cite">
<br>
From 4911463b9ef5ce6276bc52dafa0ed61381ff329d Mon Sep
17 00:00:00 2001
<br>
From: Michal Zidek<a class="moz-txt-link-rfc2396E" href="mailto:mzidek@redhat.com"><mzidek@redhat.com></a>
<br>
Date: Fri, 21 Nov 2014 20:12:11 +0100
<br>
Subject: [PATCH 2/2] AD: Never store case_sensitive as
"true" to confdb
<br>
<br>
If case_sensitive was set 'true' for AD
<br>
backend, we ignore it and continue with AD
<br>
default (false). However we still set confdb
<br>
to whatever was set in sssd.conf for the
<br>
responders. We should store to confdb
<br>
the value that is used by the backend.
<br>
<br>
Also fixes some misleading DEBUG messages
<br>
in that code area.
<br>
---
<br>
src/providers/ad/ad_common.c | 15 +++++++++++----
<br>
1 file changed, 11 insertions(+), 4 deletions(-)
<br>
<br>
diff --git a/src/providers/ad/ad_common.c
b/src/providers/ad/ad_common.c
<br>
index 7b08c2b..c9c7931 100644
<br>
--- a/src/providers/ad/ad_common.c
<br>
+++ b/src/providers/ad/ad_common.c
<br>
@@ -264,6 +264,7 @@ ad_get_common_options(TALLOC_CTX
*mem_ctx,
<br>
char *ad_hostname;
<br>
char hostname[HOST_NAME_MAX + 1];
<br>
char *case_sensitive_opt;
<br>
+ char *opt_override;
<br>
<br>
opts = talloc_zero(mem_ctx, struct ad_options);
<br>
if (!opts) return ENOMEM;
<br>
@@ -359,20 +360,26 @@ ad_get_common_options(TALLOC_CTX
*mem_ctx,
<br>
goto done;
<br>
}
<br>
<br>
+ opt_override = talloc_strdup(mem_ctx,
<br>
+
dom->case_preserve ? "preserving" : "false");
<br>
</blockquote>
Do we really have to allocate memory on heap?
<br>
</blockquote>
<br>
I did to avoid calling discard_const_p. I also think the
code
<br>
is easier to follow if the opt_override is used instead of
<br>
string literrals.
<br>
<br>
</blockquote>
NACK
<br>
<br>
4th argument is not modified in confdb_set_string thus API
can be changed
<br>
</blockquote>
<br>
True, but also completely unrelated to this patch.
<br>
</blockquote>
That's not really true.
<br>
<br>
Michal wanted to avoid to using discard_const_p, therefore he
called
<br>
talloc_strdup which is overkill in this case.
<br>
<br>
LS
<br>
</blockquote>
<br>
I agree with Lukas. I was not thinking clearly and got myself
<br>
into some 'discard const warning disposal' trap. New patches
<br>
attached.
<br>
<br>
Michal
<br>
<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
sssd-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:sssd-devel@lists.fedorahosted.org">sssd-devel@lists.fedorahosted.org</a>
<a class="moz-txt-link-freetext" href="https://lists.fedorahosted.org/mailman/listinfo/sssd-devel">https://lists.fedorahosted.org/mailman/listinfo/sssd-devel</a>
</pre>
</blockquote>
ACK<br>
</body>
</html>