<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<br>
<div class="moz-cite-prefix">On 11/25/2014 04:48 PM, Lukas Slebodnik
wrote:<br>
</div>
<blockquote cite="mid:20141125154802.GK2590@mail.corp.redhat.com"
type="cite">
<pre wrap="">On (25/11/14 16:32), Pavel Reichl wrote:
</pre>
<blockquote type="cite">
<pre wrap="">
On 11/25/2014 03:33 PM, Lukas Slebodnik wrote:
</pre>
<blockquote type="cite">
<pre wrap="">On (14/10/14 14:44), Lukas Slebodnik wrote:
</pre>
<blockquote type="cite">
<pre wrap="">On (14/10/14 14:14), Pavel Reichl wrote:
</pre>
<blockquote type="cite">
<pre wrap="">On 10/14/2014 01:59 PM, Lukas Slebodnik wrote:
</pre>
<blockquote type="cite">
<pre wrap="">diff --git a/src/util/sss_krb5.c b/src/util/sss_krb5.c
index b4012593d96bc951143e4bb2ba7a91d118b1a53c..7daedb47464917966350f94c7d5b0844ccee7edb 100644
--- a/src/util/sss_krb5.c
+++ b/src/util/sss_krb5.c
@@ -834,8 +834,15 @@ void sss_krb5_get_init_creds_opt_set_canonicalize(krb5_get_init_creds_opt *opts,
void sss_krb5_princ_realm(krb5_context context, krb5_const_principal princ,
const char **realm, int *len)
{
- *realm = krb5_principal_get_realm(context, princ);
- *len = strlen(*realm);
+ const char *realm_str = krb5_principal_get_realm(context, princ);
+
+ if (realm_str != NULL) {
+ *realm = krb5_principal_get_realm(context, princ);
</pre>
</blockquote>
<pre wrap="">Why do we have to call krb5_principal_get_realm() again here? Why can't we
just reuse value in realm_str?
</pre>
</blockquote>
<pre wrap="">I just forgot to squash changes before sending patches.
Updated version is attached.
</pre>
</blockquote>
<pre wrap="">Attached are updated patches which can be applied on current master.
LS
</pre>
</blockquote>
<pre wrap="">I think you rebased wrong patch - there were some changes which are not in
this patch - you can see my prev post and you reaction to see what I mean.
</pre>
</blockquote>
<pre wrap="">yep,
I just sent wrong patch. The problematic was the 2nd patch.
LS
</pre>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
sssd-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:sssd-devel@lists.fedorahosted.org">sssd-devel@lists.fedorahosted.org</a>
<a class="moz-txt-link-freetext" href="https://lists.fedorahosted.org/mailman/listinfo/sssd-devel">https://lists.fedorahosted.org/mailman/listinfo/sssd-devel</a>
</pre>
</blockquote>
LGTM, builds fine. ACK<br>
</body>
</html>