<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<br>
<div class="moz-cite-prefix">On 10/06/2014 11:20 AM, Pavel Reichl
wrote:<br>
</div>
<blockquote cite="mid:54325EC4.5070209@redhat.com" type="cite">
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
<br>
<div class="moz-cite-prefix">On 01/30/2014 11:35 AM, Denis Kutin
wrote:<br>
</div>
<blockquote
cite="mid:CANeHAkhoA_SSpkWqO074b5J4DFqaTqAe1u4TH0T_TVEbB2Ufhg@mail.gmail.com"
type="cite">
<div dir="ltr">
<div style="font-family:arial,sans-serif;font-size:13px">Dear
friends, </div>
<div style="font-family:arial,sans-serif;font-size:13px"><br>
</div>
<div style="font-family:arial,sans-serif;font-size:13px">Using
sssd, for a long time, I have come across with a problem
recently, which I would like to solve with your help.</div>
<div style="font-family:arial,sans-serif;font-size:13px"><br>
</div>
<div style="font-family:arial,sans-serif;font-size:13px">I
provide centralized authentication and authorization service
for a huge heterogeneous network. And in my case it would be
"nice and easy" if sssd used only shells(5). I believe this
mechanism is sufficient for identification of an allowed
shell.</div>
<div style="font-family:arial,sans-serif;font-size:13px"><br>
</div>
<div style="font-family:arial,sans-serif;font-size:13px">I
take a liberty to offer you this tiny patch, which will let
use wildcard (*) in param allowed_shells in sssd.conf</div>
<div style="font-family:arial,sans-serif;font-size:13px"><br>
</div>
<div style="font-family:arial,sans-serif;font-size:13px">What
do you think about it?</div>
<div><br>
</div>
-- <br>
<div>Denis Kutin</div>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
sssd-devel mailing list
<a moz-do-not-send="true" class="moz-txt-link-abbreviated" href="mailto:sssd-devel@lists.fedorahosted.org">sssd-devel@lists.fedorahosted.org</a>
<a moz-do-not-send="true" class="moz-txt-link-freetext" href="https://lists.fedorahosted.org/mailman/listinfo/sssd-devel">https://lists.fedorahosted.org/mailman/listinfo/sssd-devel</a>
</pre>
</blockquote>
Hello Denis, <br>
<br>
You patch seems to generally solve the problem. But there are some
minor nitpicks with it: <br>
* it needs rebasing (update debug message format) <br>
* move check out of loop <br>
* do not make lines longer then 80 chars <br>
* probably document your use case would be helpful <br>
<br>
Are you willing to do the changes? <br>
If you are too busy I can do the changes myself. You would still
keep the authorship of the patch. I would be just named in
Signed-off-by tag. Would that work for you? <br>
<br>
Thanks again for the patch! <br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
sssd-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:sssd-devel@lists.fedorahosted.org">sssd-devel@lists.fedorahosted.org</a>
<a class="moz-txt-link-freetext" href="https://lists.fedorahosted.org/mailman/listinfo/sssd-devel">https://lists.fedorahosted.org/mailman/listinfo/sssd-devel</a>
</pre>
</blockquote>
Hello,<br>
<br>
I took the liberty and prepared the patch.<br>
<br>
Thanks.<br>
</body>
</html>