<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
On 01/13/2014 06:00 AM, Lukas Slebodnik wrote:
<blockquote cite="mid:20140113110002.GD949@mail.corp.redhat.com"
type="cite">
<pre wrap="">ehlo,
Attached patches fix warnings with compiler flag Wmissing-prototypes.
In my opinion, it is better declare function with static modifier if function
is not part of public API.
patch 0002-Use-static-modifier-for-unit-test-functions.patch helps me find out
that negative_test was not execupted as part of INI unit tests.
0004-REFARRAY-Move-declaration-of-ref_array_debug-to-priv.patch
It is better to have declaration in private header file, beacuse it prevents
copy&paste errors. Declaration in file ini/ini_valueobj_ut.c was wrong.
The last patch enables extra compiler warnings including Wmissing-prototypes.
LS
</pre>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
sssd-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:sssd-devel@lists.fedorahosted.org">sssd-devel@lists.fedorahosted.org</a>
<a class="moz-txt-link-freetext" href="https://lists.fedorahosted.org/mailman/listinfo/sssd-devel">https://lists.fedorahosted.org/mailman/listinfo/sssd-devel</a>
</pre>
</blockquote>
I looked at the patches again. They seem fine.<br>
I looks like collection has all the debug functions already exposed
and public.<br>
<br>
Let us make ref_array_debug public too as is. If it changes we will
add a different function. So far I do not see a reason for it to
change.<br>
<br>
Does this simplify things?<br>
<br>
<pre class="moz-signature" cols="72">--
Thank you,
Dmitri Pal
Sr. Engineering Manager for IdM portfolio
Red Hat Inc.
-------------------------------
Looking to carve out IT costs?
<a class="moz-txt-link-abbreviated" href="http://www.redhat.com/carveoutcosts/">www.redhat.com/carveoutcosts/</a>
</pre>
</body>
</html>