<div dir="ltr"><div>Required changes done. Please check the patch.<br><br></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Apr 12, 2013 at 9:28 PM, Jakub Hrozek <span dir="ltr"><<a href="mailto:jhrozek@redhat.com" target="_blank">jhrozek@redhat.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">On Thu, Apr 11, 2013 at 01:47:03PM +0200, Lukas Slebodnik wrote:<br>
> On (11/04/13 11:18), Jakub Hrozek wrote:<br>
> >On Thu, Apr 11, 2013 at 11:04:06AM +0200, Lukas Slebodnik wrote:<br>
> >> I wanted to revie som patches, but test failed with unrelated issue to revieved<br>
> >> patch.<br>
> >><br>
> ><br>
> >The test_io.c test should also call tests_set_cwd().<br>
> ><br>
> >Is this only an issue with test_io.c ? Did sysdb_tests run OK? I would<br>
> >expect them to have the same problem, can you check?<br>
><br>
> I fixed also tests_set_cwd(), there was ignored return value if TEST_DIR is empty<br>
> string. It should not happen with default TEST_DIR value.<br>
><br>
> Attached patch just fix segmentation fault and improve some lines to prevent<br>
> segfault.<br>
><br>
> Abhishek can rewrite test_io.c to using tests_set_cwd(),<br>
> (use relative paths)<br>
> Also there something what is not very good solution (transformation to relativepath)<br>
><br>
> relativepath = strchr(get_filepath(path), 't');<br>
> ^^^^^<br>
> What if I decide to call ./configure --with-test-dir="temp_test"?<br>
><br>
> LS<br>
<br>
</div></div>Lukas, please send a patch that would fix the above with calling basename,<br>
please. We need to fix this in master asap.<br>
</blockquote></div><br></div>