<div dir="ltr">changes done.<br></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Sat, Mar 23, 2013 at 12:07 AM, Stephen Gallagher <span dir="ltr">&lt;<a href="mailto:sgallagh@redhat.com" target="_blank">sgallagh@redhat.com</a>&gt;</span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">-----BEGIN PGP SIGNED MESSAGE-----<br>
Hash: SHA1<br>
<br>
</div><div class="im">On 03/22/2013 02:33 PM, Abhishek Singh wrote:<br>
&gt; New tests added to success tests. Please review it.<br>
&gt;<br>
<br>
</div>Almost :)<br>
<br>
You can&#39;t just test for integer equivalence, because it&#39;s conceivable<br>
that there may be other flags returned beyond just the FD_CLOEXEC flag.<br>
<br>
You need to do:<br>
assert_true(ret_flag &amp; FD_CLOEXEC)<br>
<br>
The bitwise comparison will ensure that it&#39;s non-zero if the<br>
FD_CLOEXEC flag is set.<br>
<div class="im">-----BEGIN PGP SIGNATURE-----<br>
Version: GnuPG v1.4.13 (GNU/Linux)<br>
Comment: Using GnuPG with Thunderbird - <a href="http://www.enigmail.net/" target="_blank">http://www.enigmail.net/</a><br>
<br>
</div>iEYEARECAAYFAlFMpO4ACgkQeiVVYja6o6OJsQCfeifrXZefJL2CfKR5qFl267XG<br>
LzwAn2AzSlodw/YfT1phEHOFuk6fTXSs<br>
=EyN7<br>
-----END PGP SIGNATURE-----<br>
<div class="HOEnZb"><div class="h5">_______________________________________________<br>
sssd-devel mailing list<br>
<a href="mailto:sssd-devel@lists.fedorahosted.org">sssd-devel@lists.fedorahosted.org</a><br>
<a href="https://lists.fedorahosted.org/mailman/listinfo/sssd-devel" target="_blank">https://lists.fedorahosted.org/mailman/listinfo/sssd-devel</a><br>
</div></div></blockquote></div><br></div>