<html>
  <head>
    <meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    <div class="moz-cite-prefix">On 09/05/2012 03:16 AM, Ariel Barria
      wrote:<br>
    </div>
    <blockquote cite="mid:SNT120-W14973DD9A8A5CB36D82752D2A90@phx.gbl"
      type="cite">
      <style><!--
.hmmessage P
{
margin:0px;
padding:0px
}
body.hmmessage
{
font-size: 10pt;
font-family:Tahoma
}
--></style>
      <div dir="ltr">
        &gt; Date: Mon, 3 Sep 2012 17:16:53 +0200<br>
        <div>&gt; From: <a class="moz-txt-link-abbreviated" href="mailto:jhrozek@redhat.com">jhrozek@redhat.com</a><br>
          &gt; To: <a class="moz-txt-link-abbreviated" href="mailto:sssd-devel@lists.fedorahosted.org">sssd-devel@lists.fedorahosted.org</a><br>
          &gt; Subject: Re: [SSSD] [PATCH] - SIGUSR2 should force SSSD
          to reread resolv.conf as well<br>
          &gt; <br>
          &gt; On Mon, Sep 03, 2012 at 12:14:53AM -0500, Ariel Barria
          wrote:<br>
          &gt; &gt; <br>
          &gt; &gt; sorry if I made ​​them waste time.<br>
          &gt; &gt; Well after some drawbacks to create the test
          environment seems to be already.<br>
          &gt; &gt; &gt;Nack. Did you test this?<br>
          &gt; &gt; <br>
          &gt; &gt; &gt;The function monitor_config_file() just adds a
          file to the list of files<br>
          &gt; &gt; &gt;that are being monitored. What you need to do is
          call to signal all of<br>
          &gt; &gt; &gt;the monitor's children to perform a res_init()
          with<br>
          &gt; &gt; &gt;service_signal_res_init().<br>
          &gt; &gt; <br>
          &gt; &gt; <br>
          &gt; &gt; yes, I not knew some features in vimrc.<br>
          &gt; &gt; I added these revisions :)<br>
          &gt; &gt; <br>
          &gt; &gt; &gt;Also, as Dmitri mentioned, *please* fix the
          whitespace issues. We use<br>
          &gt; &gt; &gt;four spaces for indentation. No tabs, please.<br>
          &gt; <br>
          &gt; Much better, Ariel, thank you!<br>
          &gt; <br>
          &gt; I have two very minor requests to make the patch more
          readable:<br>
          &gt; <br>
          &gt; 1) I think you can reuse service_signal_dns_reload
          instead of the<br>
          &gt; new function service_signal_res_init, the two functions
          are<br>
          &gt; identical. It is good practice to keep the code
          duplication as low<br>
          &gt; as possible.<br>
          <br>
          done.<br>
          <br>
          &gt; 2) I don't understand why you pass the private void
          pointer to<br>
          &gt; signal_res_init() instead of passing struct mt_ctx *
          directly?<br>
          &gt; Can you either pass the monitor context directly or fold<br>
          &gt; signal_res_init() into signal_offline_reset()<br>
          <br>
          I spent monitor context directly.<br>
          <br>
          &gt; Functionally, the patch is fine. Thanks again.<br>
          thank to you for your comment.<br>
          <br>
          &gt; _______________________________________________<br>
          &gt; sssd-devel mailing list<br>
          &gt; <a class="moz-txt-link-abbreviated" href="mailto:sssd-devel@lists.fedorahosted.org">sssd-devel@lists.fedorahosted.org</a><br>
          &gt;
          <a class="moz-txt-link-freetext" href="https://lists.fedorahosted.org/mailman/listinfo/sssd-devel">https://lists.fedorahosted.org/mailman/listinfo/sssd-devel</a><br>
        </div>
      </div>
      <br>
      <fieldset class="mimeAttachmentHeader"></fieldset>
      <br>
      <pre wrap="">_______________________________________________
sssd-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:sssd-devel@lists.fedorahosted.org">sssd-devel@lists.fedorahosted.org</a>
<a class="moz-txt-link-freetext" href="https://lists.fedorahosted.org/mailman/listinfo/sssd-devel">https://lists.fedorahosted.org/mailman/listinfo/sssd-devel</a>
</pre>
    </blockquote>
    <br>
    Looks good to me.<br>
    Ack.<br>
    <br>
    Michal<br>
  </body>
</html>