<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 09/05/2012 03:16 AM, Ariel Barria
wrote:<br>
</div>
<blockquote cite="mid:SNT120-W14973DD9A8A5CB36D82752D2A90@phx.gbl"
type="cite">
<style><!--
.hmmessage P
{
margin:0px;
padding:0px
}
body.hmmessage
{
font-size: 10pt;
font-family:Tahoma
}
--></style>
<div dir="ltr">
> Date: Mon, 3 Sep 2012 17:16:53 +0200<br>
<div>> From: <a class="moz-txt-link-abbreviated" href="mailto:jhrozek@redhat.com">jhrozek@redhat.com</a><br>
> To: <a class="moz-txt-link-abbreviated" href="mailto:sssd-devel@lists.fedorahosted.org">sssd-devel@lists.fedorahosted.org</a><br>
> Subject: Re: [SSSD] [PATCH] - SIGUSR2 should force SSSD
to reread resolv.conf as well<br>
> <br>
> On Mon, Sep 03, 2012 at 12:14:53AM -0500, Ariel Barria
wrote:<br>
> > <br>
> > sorry if I made them waste time.<br>
> > Well after some drawbacks to create the test
environment seems to be already.<br>
> > >Nack. Did you test this?<br>
> > <br>
> > >The function monitor_config_file() just adds a
file to the list of files<br>
> > >that are being monitored. What you need to do is
call to signal all of<br>
> > >the monitor's children to perform a res_init()
with<br>
> > >service_signal_res_init().<br>
> > <br>
> > <br>
> > yes, I not knew some features in vimrc.<br>
> > I added these revisions :)<br>
> > <br>
> > >Also, as Dmitri mentioned, *please* fix the
whitespace issues. We use<br>
> > >four spaces for indentation. No tabs, please.<br>
> <br>
> Much better, Ariel, thank you!<br>
> <br>
> I have two very minor requests to make the patch more
readable:<br>
> <br>
> 1) I think you can reuse service_signal_dns_reload
instead of the<br>
> new function service_signal_res_init, the two functions
are<br>
> identical. It is good practice to keep the code
duplication as low<br>
> as possible.<br>
<br>
done.<br>
<br>
> 2) I don't understand why you pass the private void
pointer to<br>
> signal_res_init() instead of passing struct mt_ctx *
directly?<br>
> Can you either pass the monitor context directly or fold<br>
> signal_res_init() into signal_offline_reset()<br>
<br>
I spent monitor context directly.<br>
<br>
> Functionally, the patch is fine. Thanks again.<br>
thank to you for your comment.<br>
<br>
> _______________________________________________<br>
> sssd-devel mailing list<br>
> <a class="moz-txt-link-abbreviated" href="mailto:sssd-devel@lists.fedorahosted.org">sssd-devel@lists.fedorahosted.org</a><br>
>
<a class="moz-txt-link-freetext" href="https://lists.fedorahosted.org/mailman/listinfo/sssd-devel">https://lists.fedorahosted.org/mailman/listinfo/sssd-devel</a><br>
</div>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
sssd-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:sssd-devel@lists.fedorahosted.org">sssd-devel@lists.fedorahosted.org</a>
<a class="moz-txt-link-freetext" href="https://lists.fedorahosted.org/mailman/listinfo/sssd-devel">https://lists.fedorahosted.org/mailman/listinfo/sssd-devel</a>
</pre>
</blockquote>
<br>
Looks good to me.<br>
Ack.<br>
<br>
Michal<br>
</body>
</html>