<html><body><div style="color:#000; background-color:#fff; font-family:times new roman, new york, times, serif;font-size:12pt"><div><span>Thanks, we will test the 1.5 patches and report back if we run into any issues.<br></span></div><div><br></div> <div style="font-family: times new roman, new york, times, serif; font-size: 12pt;"> <div style="font-family: times new roman, new york, times, serif; font-size: 12pt;"> <div dir="ltr"> <font face="Arial" size="2"> <hr size="1"> <b><span style="font-weight:bold;">From:</span></b> Stephen Gallagher <sgallagh@redhat.com><br> <b><span style="font-weight: bold;">To:</span></b> Development of the System Security Services Daemon <sssd-devel@lists.fedorahosted.org> <br><b><span style="font-weight: bold;">Cc:</span></b> Shantanu Goel <sgoel01@yahoo.com> <br> <b><span style="font-weight: bold;">Sent:</span></b> Monday, June 18, 2012 2:43 PM<br> <b><span style="font-weight:
bold;">Subject:</span></b> Re: [SSSD] [PATCH] Add support for terminating idle connections in sssd_nss<br> </font> </div> <br>
On Mon, 2012-06-18 at 14:11 -0400, Simo Sorce wrote:<br>> On Mon, 2012-06-18 at 13:49 -0400, Stephen Gallagher wrote:<br>> > On Mon, 2012-06-18 at 13:32 -0400, Simo Sorce wrote:<br>> > > On Mon, 2012-06-18 at 11:33 -0400, Stephen Gallagher wrote:<br>> > > > On Mon, 2012-06-18 at 09:33 -0400, Stephen Gallagher wrote:<br>> > > > > On Mon, 2012-06-18 at 06:30 -0700, Shantanu Goel wrote:<br>> > > > > > Hi Stephen,<br>> > > > > > <br>> > > > > > <br>> > > > > > Please feel free to modify the patch in any way or shape you deem<br>> > > > > > necessary for inclusion. We are just glad that you agree there is a<br>> > > > > > real problem which needs fixing. One thing I ask is if you expect to<br>> > > > > > have rhel 5 or 6 test RPMs that we could test with the ultimate fix<br>>
> > > > > any time soon, please drop me a note and we will gladly install them<br>> > > > > > on some of our problematic machines here to see if they address the<br>> > > > > > problems we have seen.<br>> > > > > <br>> > > > > Sure, once this is done I'm going to be committing it upstream for the<br>> > > > > master branch (future 1.9), the sssd-1-8 branch (our current LTM<br>> > > > > release) and the sssd-1-5 branch (our previous LTM release).<br>> > > > > <br>> > > > > You should be able to pull the patches from the sssd-1-5 branch and<br>> > > > > build them for your systems once they're ready.<br>> > > > <br>> > > > Ok, new patches attached. Shantanu, these are currently designed for the<br>> > > > master branch. We'll get them committed there first and tested
out for a<br>> > > > little while, then we'll backport them.<br>> > > > <br>> > > > Patch 0001: Return the correct errno value. Previously it could have<br>> > > > been reset by closing the socket.<br>> > > > <br>> > > > Patch 0002: Add some additional debugging to the client_destructor()<br>> > > > <br>> > > > Patch 0003: On systems that support MSG_NOSIGNAL, we should use it. This<br>> > > > way, if a client app isn't configured to listen for SIGPIPE, it will not<br>> > > > crash.<br>> > > > <br>> > > > Patch 0004: Add a timer to each client context. If sixty seconds pass<br>> > > > (configurable in the patch 0005) without either read or write activity,<br>> > > > we will free the client context and close the socket. The client code is<br>> > > > already written to be
tolerant of this and will reconnect on the next<br>> > > > request. This will help us avoid resource exhaustion if we have clients<br>> > > > that hang on to NSS and PAM file descriptors indefinitely (like 'su' and<br>> > > > 'login' do for PAM).<br>> > > > <br>> > > > Patch 0005: Make the client idle timeout value configurable and add it<br>> > > > to the manpages and config API.<br>> > > <br>> > > 0001 ack<br>> > > 0002 ack<br>> > > 0003 Please always use send with a default set of flags, make the ifdef<br>> > > set the default set of flags (0 vs MSG_NOSIGNAL)<br>> > > 0004 ack (not like much the TODO but I was told 4/5 got split for<br>> > > reviewability, so ok)<br>> > > 0005 ack<br>> > <br>> > <br>> > <br>> > Thanks for the review. New patches attached.<br>> <br>> ack to
all.<br><br><br>Pushed to master. Also backported to sssd-1-8 and sssd-1-5 and pushed<br>there as well. See attachments for the exact backported patches.<br><br><br> </div> </div> </div></body></html>