<html>
<head>
<style><!--
.hmmessage P
{
margin:0px;
padding:0px
}
body.hmmessage
{
font-size: 10pt;
font-family:Tahoma
}
--></style></head>
<body class='hmmessage'><div dir='ltr'>
thanks for comments.<br><br><div><div id="SkyDrivePlaceholder"></div>From: sgallagh@redhat.com<br>To: sssd-devel@lists.fedorahosted.org<br>Date: Wed, 13 Jun 2012 07:27:54 -0400<br>Subject: Re: [SSSD] [PATCH]-Bad debug message when adding services without explicit dns_discovery_domain<br><br><pre>On Tue, 2012-06-12 at 23:20 -0500, Ariel Barria wrote:<br>&gt; thanks for comments<br>&gt; <br>&gt; <br>&gt; &gt; From: simo@redhat.com<br>&gt; &gt; To: sssd-devel@lists.fedorahosted.org<br>&gt; &gt; Date: Tue, 12 Jun 2012 08:30:07 -0400<br>&gt; &gt; Subject: Re: [SSSD] [PATCH]-Bad debug message when adding services<br>&gt; without explicit dns_discovery_domain<br>&gt; &gt; <br>&gt; &gt; On Tue, 2012-06-12 at 11:11 +0200, Jakub Hrozek wrote:<br>&gt; &gt; &gt; On Tue, Jun 12, 2012 at 11:04:28AM +0200, Jan Zelený wrote:<br>&gt; &gt; &gt; &gt; &gt; <a href="https://fedorahosted.org/sssd/ticket/920" target="_blank">https://fedorahosted.org/sssd/ticket/920</a><br>&gt; &gt; &gt; &gt; <br>&gt; &gt; &gt; &gt; Nack,<br>&gt; &gt; &gt; &gt; please follow our coding guidelines:<br>&gt; &gt; &gt; &gt; <br>&gt; &gt; &gt; &gt; <a href="http://www.freeipa.org/page/Coding_Style" target="_blank">http://www.freeipa.org/page/Coding_Style</a><br>&gt; &gt; &gt; &gt; <br>&gt; &gt; &gt; &gt; In particular, I'm referring to the line length.<br>&gt; &gt; &gt; &gt; <br>&gt; &gt; &gt; &gt; Thanks<br>&gt; &gt; &gt; &gt; Jan<br>&gt; &gt; &gt; <br>&gt; &gt; &gt; Please also change the debug message to appropriate symbolic<br>&gt; constant.<br>&gt; &gt; <br>&gt; &gt; s/message/level/ I guess :)<br>&gt; &gt; <br> <br> <br>Nack<br> <br>First of all, you're still not following our style guidelines. Please do<br>not use tabs anywhere, keep your lines to 79 charcacters and do not have<br>trailing spaces in the lines.<br> <br>Now, for the meat of the problem. The message that you're printing is<br>incorrect. We don't want to print the literal strings "example.com" and<br>"DOMAINNAME".<br> <br>"DOMAINNAME" should be replaced by the input  string sssd_domain. <br> <br>Unfortunately, at this stage of evaluation we do not have the actual DNS<br>domain to print, so we'll have to replace "example.com" with "the<br>machine's DNS domain name".<br> <br></pre><br>_______________________________________________
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/sssd-devel</div>                                               </div></body>
</html>