From 686ddf64016fda7258a6cb4c3730061678ddff5e Mon Sep 17 00:00:00 2001
From: Stephen Gallagher <sgallagh@redhat.com>
Date: Fri, 11 Sep 2009 11:23:09 -0400
Subject: [PATCH] Add strtoint32 and strtouint32 tests

---
 server/Makefile.am            |   11 +
 server/tests/strtonum-tests.c |  454 +++++++++++++++++++++++++++++++++++++++++
 2 files changed, 465 insertions(+), 0 deletions(-)
 create mode 100644 server/tests/strtonum-tests.c

diff --git a/server/Makefile.am b/server/Makefile.am
index 18fb699..50439b2 100644
--- a/server/Makefile.am
+++ b/server/Makefile.am
@@ -57,6 +57,7 @@ sssdlibexec_PROGRAMS = \
 if HAVE_CHECK
     non_interactive_check_based_tests = \
         sysdb-tests \
+        strtonum-tests \
         resolv-tests
 endif
 
@@ -343,6 +344,16 @@ sysdb_tests_CFLAGS = \
 sysdb_tests_LDADD = \
     $(SSSD_LIBS) \
     $(CHECK_LIBS)
+    
+strtonum_tests_SOURCES = \
+    tests/strtonum-tests.c \
+    util/debug.c \
+    util/strtonum.c
+strtonum_tests_CFLAGS = \
+    $(CHECK_CFLAGS)
+strtonum_tests_LDADD = \
+    $(SSSD_LIBS) \
+    $(CHECK_LIBS)
 endif
 
 stress_tests_SOURCES = \
diff --git a/server/tests/strtonum-tests.c b/server/tests/strtonum-tests.c
new file mode 100644
index 0000000..9aa82a0
--- /dev/null
+++ b/server/tests/strtonum-tests.c
@@ -0,0 +1,454 @@
+/*
+   SSSD
+
+   InfoPipe
+
+   Copyright (C) Stephen Gallagher <sgallagh@redhat.com>	2009
+
+   This program is free software; you can redistribute it and/or modify
+   it under the terms of the GNU General Public License as published by
+   the Free Software Foundation; either version 3 of the License, or
+   (at your option) any later version.
+
+   This program is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+   GNU General Public License for more details.
+
+   You should have received a copy of the GNU General Public License
+   along with this program.  If not, see <http://www.gnu.org/licenses/>.
+*/
+
+#include <stdlib.h>
+#include <check.h>
+#include <errno.h>
+#include <popt.h>
+#include "util/util.h"
+#include "util/strtonum.h"
+
+/********************
+ * Utility routines *
+ ********************/
+#define EXPECT_UNSET_ERRNO(error) \
+    do { \
+        fail_unless(error == 0, "errno unexpectedly set to %d[%s]", \
+                                error, strerror(error)); \
+    } while(0)
+
+#define CHECK_RESULT(expected, actual) \
+    do { \
+        fail_unless(result == expected, "Expected %ld, got %ld", \
+                                        expected, result); \
+    } while(0)
+
+#define CHECK_ERRNO(expected, actual) \
+    do { \
+        fail_unless(error == ERANGE, "Expected errno %d[%s], got %d[%s]", \
+                                     ERANGE, strerror(ERANGE), \
+                                     error, strerror(ERANGE)); \
+    } while(0)
+
+#define CHECK_ENDPTR(expected, actual) \
+    do { \
+        fail_unless(actual == expected, "Expected endptr %p, got %p", \
+                                         expected, actual); \
+    } while(0)
+
+#define CHECK_ZERO_ENDPTR(endptr) \
+    do { \
+        fail_unless(endptr && *endptr == '\0', "Invalid endptr"); \
+    } while(0);
+
+/******************
+ * strtoint tests *
+ ******************/
+
+/* Base-10 */
+START_TEST (test_strtoint32_pos_integer_base_10)
+{
+    int32_t result;
+    const char *input = "123";
+    int32_t expected = 123;
+    char *endptr;
+    errno_t error;
+
+    result = strtoint32(input, &endptr, 10);
+    error = errno;
+
+    EXPECT_UNSET_ERRNO(error);
+    CHECK_ZERO_ENDPTR(endptr);
+    CHECK_RESULT(expected, result);
+}
+END_TEST
+
+START_TEST (test_strtoint32_neg_integer_base_10)
+{
+    int32_t result;
+    const char *input = "-123";
+    int32_t expected = -123;
+    char *endptr;
+    errno_t error;
+
+    result = strtoint32(input, &endptr, 10);
+    error = errno;
+
+    EXPECT_UNSET_ERRNO(error);
+    CHECK_ZERO_ENDPTR(endptr);
+    CHECK_RESULT(expected, result);
+}
+END_TEST
+
+START_TEST (test_strtoint32_pos_integer_intmax_base_10)
+{
+    int32_t result;
+    const char *input = "2147483647";
+    int32_t expected = INT32_MAX;
+    char *endptr;
+    errno_t error;
+
+    result = strtoint32(input, &endptr, 10);
+    error = errno;
+
+    EXPECT_UNSET_ERRNO(error);
+    CHECK_ZERO_ENDPTR(endptr);
+    CHECK_RESULT(expected, result);
+}
+END_TEST
+
+START_TEST (test_strtoint32_neg_integer_intmin_base_10)
+{
+    int32_t result;
+    const char *input = "-2147483648";
+    int32_t expected = INT32_MIN;
+    char *endptr;
+    errno_t error;
+
+    result = strtoint32(input, &endptr, 10);
+    error = errno;
+
+    EXPECT_UNSET_ERRNO(error);
+    CHECK_ZERO_ENDPTR(endptr);
+    CHECK_RESULT(expected, result);
+}
+END_TEST
+
+START_TEST (test_strtoint32_pos_integer_overflow_base_10)
+{
+    int32_t result;
+    const char *input = "8589934592";
+    int32_t expected = INT32_MAX;
+    char *endptr;
+    errno_t error;
+
+    result = strtoint32(input, &endptr, 10);
+    error = errno;
+
+    CHECK_ERRNO(ERANGE, error);
+    CHECK_ZERO_ENDPTR(endptr);
+    CHECK_RESULT(expected, actual);
+}
+END_TEST
+
+START_TEST (test_strtoint32_pos_integer_underflow_base_10)
+{
+    int32_t result;
+    const char *input = "-8589934592";
+    int32_t expected = INT32_MIN;
+    char *endptr;
+    errno_t error;
+
+    result = strtoint32(input, &endptr, 10);
+    error = errno;
+
+    CHECK_ERRNO(ERANGE, error);
+    CHECK_ZERO_ENDPTR(endptr);
+    CHECK_RESULT(expected, actual);
+}
+END_TEST
+
+START_TEST (test_strtoint32_mixed_alphanumeric_base_10)
+{
+    int32_t result;
+    const char *input = "12b13";
+    int32_t expected = 12;
+    char *endptr;
+    const char *expected_endptr = input+2;
+    errno_t error;
+
+    result = strtoint32(input, &endptr, 10);
+    error = errno;
+
+    EXPECT_UNSET_ERRNO(error);
+    CHECK_ENDPTR(expected_endptr, endptr);
+    CHECK_RESULT(expected, result);
+}
+END_TEST
+
+START_TEST (test_strtoint32_alphaonly_base_10)
+{
+    int32_t result;
+    const char *input = "alpha";
+    int32_t expected = 0;
+    char *endptr;
+    const char *expected_endptr = input;
+    errno_t error;
+
+    result = strtoint32(input, &endptr, 10);
+    error = errno;
+
+    EXPECT_UNSET_ERRNO(error);
+    CHECK_ENDPTR(expected_endptr, endptr);
+    CHECK_RESULT(expected, result);
+}
+END_TEST
+
+START_TEST (test_strtoint32_alphastart_base_10)
+{
+    int32_t result;
+    const char *input = "alpha12345";
+    int32_t expected = 0;
+    char *endptr;
+    const char *expected_endptr = input;
+    errno_t error;
+
+    result = strtoint32(input, &endptr, 10);
+    error = errno;
+
+    EXPECT_UNSET_ERRNO(error);
+    CHECK_ENDPTR(expected_endptr, endptr);
+    CHECK_RESULT(expected, result);
+}
+END_TEST
+
+START_TEST (test_strtoint32_emptystring_base_10)
+{
+    int32_t result;
+    const char *input = "";
+    int32_t expected = 0;
+    char *endptr;
+    const char *expected_endptr = input;
+    errno_t error;
+
+    result = strtoint32(input, &endptr, 10);
+    error = errno;
+
+    EXPECT_UNSET_ERRNO(error);
+    CHECK_ENDPTR(expected_endptr, endptr);
+    CHECK_RESULT(expected, result);
+}
+END_TEST
+
+/*******************
+ * strtouint tests *
+ *******************/
+
+/* Base-10 */
+START_TEST (test_strtouint32_pos_integer_base_10)
+{
+    uint32_t result;
+    const char *input = "123";
+    uint32_t expected = 123;
+    char *endptr;
+    errno_t error;
+
+    result = strtouint32(input, &endptr, 10);
+    error = errno;
+
+    EXPECT_UNSET_ERRNO(error);
+    CHECK_ZERO_ENDPTR(endptr);
+    CHECK_RESULT(expected, result);
+}
+END_TEST
+
+START_TEST (test_strtouint32_neg_integer_base_10)
+{
+    uint32_t result;
+    const char *input = "-123";
+    uint32_t expected = -123;
+    char *endptr;
+    errno_t error;
+
+    result = strtouint32(input, &endptr, 10);
+    error = errno;
+
+    EXPECT_UNSET_ERRNO(error);
+    CHECK_ZERO_ENDPTR(endptr);
+    CHECK_RESULT(expected, result);
+}
+END_TEST
+
+START_TEST (test_strtouint32_pos_integer_uintmax_base_10)
+{
+    uint32_t result;
+    const char *input = "4294967295";
+    uint32_t expected = UINT32_MAX;
+    char *endptr;
+    errno_t error;
+
+    result = strtouint32(input, &endptr, 10);
+    error = errno;
+
+    EXPECT_UNSET_ERRNO(error);
+    CHECK_ZERO_ENDPTR(endptr);
+    CHECK_RESULT(expected, result);
+}
+END_TEST
+
+
+START_TEST (test_strtouint32_pos_integer_overflow_base_10)
+{
+    uint32_t result;
+    const char *input = "8589934592";
+    uint32_t expected = UINT32_MAX;
+    char *endptr;
+    errno_t error;
+
+    result = strtouint32(input, &endptr, 10);
+    error = errno;
+
+    CHECK_ERRNO(ERANGE, error);
+    CHECK_ZERO_ENDPTR(endptr);
+    CHECK_RESULT(expected, actual);
+}
+END_TEST
+
+START_TEST (test_strtouint32_mixed_alphanumeric_base_10)
+{
+    uint32_t result;
+    const char *input = "12b13";
+    uint32_t expected = 12;
+    char *endptr;
+    const char *expected_endptr = input+2;
+    errno_t error;
+
+    result = strtouint32(input, &endptr, 10);
+    error = errno;
+
+    EXPECT_UNSET_ERRNO(error);
+    CHECK_ENDPTR(expected_endptr, endptr);
+    CHECK_RESULT(expected, result);
+}
+END_TEST
+
+START_TEST (test_strtouint32_alphaonly_base_10)
+{
+    uint32_t result;
+    const char *input = "alpha";
+    uint32_t expected = 0;
+    char *endptr;
+    const char *expected_endptr = input;
+    errno_t error;
+
+    result = strtouint32(input, &endptr, 10);
+    error = errno;
+
+    EXPECT_UNSET_ERRNO(error);
+    CHECK_ENDPTR(expected_endptr, endptr);
+    CHECK_RESULT(expected, result);
+}
+END_TEST
+
+START_TEST (test_strtouint32_alphastart_base_10)
+{
+    uint32_t result;
+    const char *input = "alpha12345";
+    uint32_t expected = 0;
+    char *endptr;
+    const char *expected_endptr = input;
+    errno_t error;
+
+    result = strtouint32(input, &endptr, 10);
+    error = errno;
+
+    EXPECT_UNSET_ERRNO(error);
+    CHECK_ENDPTR(expected_endptr, endptr);
+    CHECK_RESULT(expected, result);
+}
+END_TEST
+
+START_TEST (test_strtouint32_emptystring_base_10)
+{
+    uint32_t result;
+    const char *input = "";
+    uint32_t expected = 0;
+    char *endptr;
+    const char *expected_endptr = input;
+    errno_t error;
+
+    result = strtouint32(input, &endptr, 10);
+    error = errno;
+
+    EXPECT_UNSET_ERRNO(error);
+    CHECK_ENDPTR(expected_endptr, endptr);
+    CHECK_RESULT(expected, result);
+}
+END_TEST
+
+
+
+Suite *create_strtonum_suite(void)
+{
+    Suite *s = suite_create("strtonum");
+
+    TCase *tc_strtoint32 = tcase_create("strtoint32 Tests");
+    tcase_add_test(tc_strtoint32, test_strtoint32_pos_integer_base_10);
+    tcase_add_test(tc_strtoint32, test_strtoint32_neg_integer_base_10);
+    tcase_add_test(tc_strtoint32, test_strtoint32_pos_integer_intmax_base_10);
+    tcase_add_test(tc_strtoint32, test_strtoint32_neg_integer_intmin_base_10);
+    tcase_add_test(tc_strtoint32, test_strtoint32_pos_integer_overflow_base_10);
+    tcase_add_test(tc_strtoint32, test_strtoint32_pos_integer_underflow_base_10);
+    tcase_add_test(tc_strtoint32, test_strtoint32_mixed_alphanumeric_base_10);
+    tcase_add_test(tc_strtoint32, test_strtoint32_alphaonly_base_10);
+    tcase_add_test(tc_strtoint32, test_strtoint32_alphastart_base_10);
+    tcase_add_test(tc_strtoint32, test_strtoint32_emptystring_base_10);
+
+    TCase *tc_strtouint32 = tcase_create("strtouint32 Tests");
+    tcase_add_test(tc_strtouint32, test_strtouint32_pos_integer_base_10);
+    tcase_add_test(tc_strtouint32, test_strtouint32_neg_integer_base_10);
+    tcase_add_test(tc_strtouint32, test_strtouint32_pos_integer_uintmax_base_10);
+    tcase_add_test(tc_strtouint32, test_strtouint32_pos_integer_overflow_base_10);
+    tcase_add_test(tc_strtouint32, test_strtouint32_mixed_alphanumeric_base_10);
+    tcase_add_test(tc_strtouint32, test_strtouint32_alphaonly_base_10);
+    tcase_add_test(tc_strtouint32, test_strtouint32_alphastart_base_10);
+    tcase_add_test(tc_strtouint32, test_strtouint32_emptystring_base_10);
+
+    /* Add all test cases to the suite */
+    suite_add_tcase(s, tc_strtoint32);
+    suite_add_tcase(s, tc_strtouint32);
+
+    return s;
+}
+
+
+int main(int argc, const char *argv[]) {
+    int opt;
+    poptContext pc;
+    int failure_count;
+    Suite *strtonum_suite;
+    SRunner *sr;
+
+    struct poptOption long_options[] = {
+        POPT_AUTOHELP
+        SSSD_MAIN_OPTS
+        { NULL }
+    };
+
+    pc = poptGetContext(argv[0], argc, argv, long_options, 0);
+    while((opt = poptGetNextOpt(pc)) != -1) {
+        switch(opt) {
+        default:
+            fprintf(stderr, "\nInvalid option %s: %s\n\n",
+                    poptBadOption(pc, 0), poptStrerror(opt));
+            poptPrintUsage(pc, stderr, 0);
+            return 1;
+        }
+    }
+    poptFreeContext(pc);
+
+    strtonum_suite = create_strtonum_suite();
+    sr = srunner_create(strtonum_suite);
+    srunner_run_all(sr, CK_VERBOSE);
+    failure_count = srunner_ntests_failed(sr);
+    srunner_free(sr);
+    return (failure_count==0 ? EXIT_SUCCESS : EXIT_FAILURE);
+}
-- 
1.6.2.5

