[SSSD] [PATCH] CI: Run integration tests on debian testing

Nikolai Kondrashov Nikolai.Kondrashov at redhat.com
Wed Sep 30 13:08:09 UTC 2015


On 09/30/2015 09:59 AM, Lukas Slebodnik wrote:
> On (29/09/15 16:47), Nikolai Kondrashov wrote:
>> >On 09/29/2015 03:41 PM, Lukas Slebodnik wrote:
>>> >>ehlo,
>>> >>
>>> >>Integration tests are enabled on debian with the last patch.
>> >
>> >So we've got more cwrap packages into Debian? Awesome:)! Or were they there
>> >all the time and I simply failed to notice them?
>> >
> uid-wrapper 1.0.2-1 was in testing since 2014-08-14
> nss-wrapper 1.0.3-2 was in testing since 2015-06-05
>
> https://packages.qa.debian.org/u/uid-wrapper.html
> https://packages.qa.debian.org/n/nss-wrapper.html

Ah, so it was added while I was working on it and I didn't notice that. Ouch.

>>> >>Here is an alternative version:
>>> >>
>>> >>diff --git a/contrib/ci/run b/contrib/ci/run
>>> >>index 5f668ff..1f64e67 100755
>>> >>--- a/contrib/ci/run
>>> >>+++ b/contrib/ci/run
>>> >>@@ -204,7 +204,7 @@ function build_debug()
>>> >>      CK_FORK=no \
>>> >>          stage make-check-valgrind \
>>> >>                  make-check-wrap -j $CPU_NUM check -- \
>>> >>-                                libtool --mode=execute \
>>> >>+                                ./libtool --mode=execute \
>>> >>                                      valgrind-condense 99 \
>>> >>                                      '!(*.py|*dlopen-tests)' -- \
>>> >>                                      --trace-children=yes \
>> >
>> >I like this way a little better, but not enough to argue:)
>> >
>
> hmm,
> I tried it but it failed in cwrap test due to different directory.
> I could use full path but nicer solution
> is to install missing dependency

Right, dependency it is then.

>>> >>All test failed due to missing /usr/bin/libtool
>>> >>
>>> >>e.g.
>>> >>/home/build/sssd/build/test-driver: line 107: libtool: command not found
>>> >>FAIL test-io (exit status: 127)
>> >
>> >Whoa! When did that start happening?
>> >
> It happens if you run script on machine with minimal dependencies.
> libtool-bin could be a dependency of another package in past.

D'oh, right.

Looks fine now, tested on my Debian laptop - worked fine.

Thank you, Lukas!

ACK.

Nick


More information about the sssd-devel mailing list