[SSSD] CI: Already fixed bug for TODO

Lukas Slebodnik lslebodn at redhat.com
Tue Sep 29 12:54:15 UTC 2015


ehlo,

I touched the CI script and I found an interesting todo

distro.sh-52-{
distro.sh-53-    declare prompt=$'Need root permissions to install packages.\n'
distro.sh-54-    prompt+="Enter sudo password for $USER: "
distro.sh-55-    if [[ "$DISTRO_BRANCH" == -redhat-* ]]; then
distro.sh-56-        [ $# != 0 ] && sudo -p "$prompt" yum --assumeyes install -- "$@" |&
distro.sh-57-            # Pass input to output, fail if a missing package is reported
distro.sh-58-            # TODO Remove and switch to DNF once
distro.sh:59:            # https://bugzilla.redhat.com/show_bug.cgi?id=1128139 is fixed
distro.sh-60-            awk 'BEGIN {s=0}
distro.sh-61-                 /^No package .* available.$/ {s=1}
distro.sh-62-                 {print}
distro.sh-63-                 END {exit s}'
distro.sh-64-    elif [[ "$DISTRO_BRANCH" == -debian-* ]]; then
distro.sh-65-        [ $# != 0 ] && sudo -p "$prompt" apt-get --yes install -- "$@"
distro.sh-66-    else


The BZ1128139 was closed as duplicate of BZ1107737.
The BZ1107737 was fixed 7 months ago and is available in
dnf >= 0.6.4-2. The Fedora 21 currently have dnf-0.6.4-7.
I think it's the best time for removing this todo.

LS


More information about the sssd-devel mailing list