[SSSD] [PATCH] SDAP: Relax POSIX check

Pavel Březina pbrezina at redhat.com
Fri Sep 25 11:31:03 UTC 2015


On 09/24/2015 05:11 PM, Pavel Reichl wrote:
>
>
> On 09/24/2015 02:12 PM, Pavel Březina wrote:
>> On 09/23/2015 10:55 PM, Pavel Reichl wrote:
>>> Yes, you are missing the rest of the patch :-)
>>>
>>>       errno = 0;
>>>       strtouint32(vals[0]->bv_val, &endptr, 10);
>>>       if (errno || *endptr || (vals[0]->bv_val == endptr)) {
>>> -        DEBUG(SSSDBG_OP_FAILURE,
>>> +        DEBUG(SSSDBG_MINOR_FAILURE,
>>>                 "POSIX attribute is not a number: %s\n",
>>> vals[0]->bv_val);
>>> -        goto done;
>>>       }
>>>
>>>
>>> We do not require attribute to be a positive number, we just warn
>>> about that. But not to make it too relaxed we added check on
>>> objectclass.
>>
>> Thanks. Code wise ack, but could you rephrase the commit message?
>>
> OK, I hope it's better now.

Yes, it is. Thank you!

Ack.



More information about the sssd-devel mailing list