[SSSD] [PATCH] CONFIGURE: Remove bashism

Lukas Slebodnik lslebodn at redhat.com
Fri Sep 25 06:13:10 UTC 2015


ehlo,

simple patch is attached.

LS
-------------- next part --------------
>From 7d5fafd567fe2ab862fb61841173097818f6a9a6 Mon Sep 17 00:00:00 2001
From: Lukas Slebodnik <lslebodn at redhat.com>
Date: Fri, 25 Sep 2015 08:00:58 +0200
Subject: [PATCH] CONFIGURE: Remove bashism

There were errors in configure script when /bin/sh was not bash
./configure: 15889: test: xfedora: unexpected operator
./configure: 19981: test: xyes: unexpected operator
./configure: 23103: test: x1: unexpected operator

The equality operator "==" works in bash but it's not a standard.
The man page test(1) also does not mention it.
There is only short version "="

       STRING1 = STRING2
              the strings are equal
---
 configure.ac                  | 2 +-
 src/conf_macros.m4            | 2 +-
 src/external/pac_responder.m4 | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/configure.ac b/configure.ac
index 291deee1ea4350eeb8e971d93b259a8d42044cca..c6debe20a06445b36caa11944c990b20f5c44adb 100644
--- a/configure.ac
+++ b/configure.ac
@@ -235,7 +235,7 @@ if test x$HAVE_MANPAGES != x; then
                      [HAVE_PROFILE_CATALOGS=1],
                      [AC_MSG_WARN([Man pages might contain documentation for experimental features])])
 
-    if test x$HAVE_PROFILE_CATALOGS == x; then
+    if test x$HAVE_PROFILE_CATALOGS = x; then
         DOCBOOK_XSLT=http://docbook.sourceforge.net/release/xsl/current/manpages/docbook.xsl
         CHECK_STYLESHEET([$SGML_CATALOG_FILES],
                          [$DOCBOOK_XSLT],
diff --git a/src/conf_macros.m4 b/src/conf_macros.m4
index cd731e605b153f69931d3cb0764f10801a596f96..619d27ccf83a24ac65c17f8efffbe09f85ba25e6 100644
--- a/src/conf_macros.m4
+++ b/src/conf_macros.m4
@@ -182,7 +182,7 @@ AC_DEFUN([WITH_INIT_DIR],
                 ]
                )
     initdir="${sysconfdir}/rc.d/init.d"
-    if test x$osname == xgentoo; then
+    if test x$osname = xgentoo; then
         initdir="${sysconfdir}/init.d"
     fi
     if test x"$with_init_dir" != x; then
diff --git a/src/external/pac_responder.m4 b/src/external/pac_responder.m4
index b57305c1d7b90b59e023b1645188f20b9be88677..2941d63ab5bc9f2c993cabf1080a04f812611751 100644
--- a/src/external/pac_responder.m4
+++ b/src/external/pac_responder.m4
@@ -9,7 +9,7 @@ AC_ARG_ENABLE([pac-responder],
 
 ndr_krb5pac_ok=no
 krb5_version_ok=no
-if test x$build_pac_responder == xyes
+if test x$build_pac_responder = xyes
 then
     PKG_CHECK_MODULES(NDR_KRB5PAC, ndr_krb5pac, ndr_krb5pac_ok=yes,
         AC_MSG_WARN([Cannot build pac responder without libndr_krb5pac]))
-- 
2.5.0



More information about the sssd-devel mailing list