[SSSD] [PATCH] AD: inicialize root_domain_attrs field

Pavel Reichl preichl at redhat.com
Thu Sep 24 15:30:21 UTC 2015



On 09/24/2015 05:11 PM, Jakub Hrozek wrote:
> On Thu, Sep 24, 2015 at 05:05:20PM +0200, Pavel Reichl wrote:
>> Hello,
>>
>> please see simple patch attached.
>>
>> Thanks!
>
> Thanks, this would solve the bug, but can you also change the allocation
> of the structure from:
>      req_ctx = talloc(be_req, struct ad_subdomains_req_ctx);
> to:
>      req_ctx = talloc_zero(be_req, struct ad_subdomains_req_ctx);
>
> So that we get a crash next time?

Sure, done. I just don't think we would get the crash sooner. I think this actually makes explicit initialization to NULL somewhat redundant. Would you like me to remove the explicit initialization?


> _______________________________________________
> sssd-devel mailing list
> sssd-devel at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-AD-inicialize-root_domain_attrs-field.patch
Type: text/x-patch
Size: 1239 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20150924/41d34f34/attachment.bin>


More information about the sssd-devel mailing list