[SSSD] [PATCH] Fix memory leak in sssdpac_verify()

Sumit Bose sbose at redhat.com
Wed Sep 23 14:48:51 UTC 2015


Hi,

the attached patch was provided by the reporter of
https://fedorahosted.org/sssd/ticket/2803 . I'm sending it here for
completeness.

I verified with valgrind that it fixes the memory leak and CI passes
http://sssd-ci.duckdns.org/logs/job/27/57/summary.html, so I gave ACK
and pushed it to 

master: b4c44ebb8997d3debb33607c123ccfd9926e0cba

Since this is a memory leak we might want to add it to other branches as
well.

bye,
Sumit
-------------- next part --------------
>From 6ea47bec27e630d44ec6eeac02143c7abf48dda8 Mon Sep 17 00:00:00 2001
From: Thomas Oulevey <thomas.oulevey at cern.ch>
Date: Wed, 23 Sep 2015 10:55:59 +0200
Subject: [PATCH] Fix memory leak in sssdpac_verify()

---
 src/sss_client/sssd_pac.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/src/sss_client/sssd_pac.c b/src/sss_client/sssd_pac.c
index 1939f61b18398f62a3e3d6b29cc4fef151b1c3b7..1d98e38826b36aed199b32880a7e27de905a4592 100644
--- a/src/sss_client/sssd_pac.c
+++ b/src/sss_client/sssd_pac.c
@@ -150,6 +150,9 @@ static krb5_error_code sssdpac_verify(krb5_context kcontext,
     kerr = krb5_pac_verify(kcontext, pac,
                            req->ticket->enc_part2->times.authtime,
                            req->ticket->enc_part2->client, key, NULL);
+    /* deallocate pac */
+    krb5_pac_free(kcontext, pac);
+    pac = NULL;
     if (kerr != 0) {
         /* The krb5 documentation says:
          * A checksum mismatch can occur if the PAC was copied from a
-- 
1.7.1



More information about the sssd-devel mailing list