[SSSD] [PATCH] confdb: warn if memcache_timeout > than entry_cache

Pavel Reichl preichl at redhat.com
Tue Sep 22 11:31:45 UTC 2015



On 09/22/2015 10:25 AM, Pavel Březina wrote:
> On 09/21/2015 04:33 PM, Pavel Reichl wrote:
>> Hello, please see simple patch attached.
>
> Hi,
> the patch looks good in general. However, I'd like to rephrase the warning.
>
>> +              "%s is lesser then %s, sysdb will not be updated for users.\n",
>                          ^lower
>
> How about:
>
> %s is lower then %s. User records will not be updated before memory cache entry expires.
>
> %s is lower then %s. User records will not be updated before memory cache entry gets expired.
> _______________________________________________

Hello Pavel, thanks for comment. I updated the patch as you proposed.

I did quick research on usage of smaller/lower/lesser and all seem to for correct for our case, but I agree that lower might sound more common.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-confdb-warn-if-memcache_timeout-than-entry_cache.patch
Type: text/x-patch
Size: 2726 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20150922/8fd2017f/attachment.bin>


More information about the sssd-devel mailing list