[SSSD] [PATCHES] DYDNDS: update quality of input for nsupdate

Pavel Březina pbrezina at redhat.com
Mon Sep 21 08:52:22 UTC 2015


On 08/28/2015 11:05 AM, Pavel Reichl wrote:
> On 08/14/2015 04:12 PM, Jakub Hrozek wrote:
>> On Thu, Aug 13, 2015 at 05:31:07PM +0200, Pavel Reichl wrote:
>>> On 08/13/2015 02:12 PM, Pavel Reichl wrote:
>>>> Sorry, this time with correct patches!
>>>>
>>>>
>>>> _______________________________________________
>>>> sssd-devel mailing list
>>>> sssd-devel at lists.fedorahosted.org
>>>> https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
>>> I updated the second patch - [PATCH 2/9] DYNDNS: Don't use server cmd in
>>> nsupdate by default
>>>
>>> I added some minor man page changes.
>>>
>>> Thanks!
>>>  From 7d786a6a102f274a685b9e84ee7fe9cdf2872590 Mon Sep 17 00:00:00 2001
>>> From: Jakub Hrozek <jhrozek at redhat.com>
>>> Date: Sun, 6 Jul 2014 22:53:27 +0200
>>> Subject: [PATCH 1/9] DYNDNS: Add a new option dyndns_server
>> The changes you requested were done to this patch. Thanks for catching
>> those.
>>
>>>  From 8a880df3631d08f195868d7de47e685a91533b09 Mon Sep 17 00:00:00 2001
>>> From: Pavel Reichl <preichl at redhat.com>
>>> Date: Thu, 23 Jul 2015 04:40:03 -0400
>>> Subject: [PATCH 2/9] DYNDNS: Don't use server cmd in nsupdate by default
>> ACK
>>
>>
>>>  From c865cd09cc418f3ddda93d0e1e73c541becb7309 Mon Sep 17 00:00:00 2001
>>> From: Pavel Reichl <preichl at redhat.com>
>>> Date: Thu, 23 Jul 2015 04:50:38 -0400
>>> Subject: [PATCH 3/9] DYNDNS: remove redundant talloc_steal()
>> ACK
>>
>>>  From 0ccb4fc0902fc29e2b452dbef4d0e6f8bb685ba4 Mon Sep 17 00:00:00 2001
>>> From: Pavel Reichl <preichl at redhat.com>
>>> Date: Thu, 23 Jul 2015 05:30:34 -0400
>>> Subject: [PATCH 4/9] DYNDNS: remove zone command
>> ACK
>>
>>>  From 0bf7d58da64c40c52b29a3d89e2e40308898b976 Mon Sep 17 00:00:00 2001
>>> From: Pavel Reichl <preichl at redhat.com>
>>> Date: Thu, 23 Jul 2015 09:52:47 -0400
>>> Subject: [PATCH 5/9] DYNDNS: rename field of sdap_dyndns_update_state
>>>
>>> Rename 'use_server_with_nsupdate' to more general name 'fallback_mode'.
>>>
>>> Resolves:
>>> https://fedorahosted.org/sssd/ticket/2495
>> ACK
>
> Missing [PATCH 6/9] DYNDNS: use realm and server commands only as fallback
>
>>
>>>  From 748d3e0f584a2469cdb7333a579a924a54c0b7dc Mon Sep 17 00:00:00 2001
>>> From: Pavel Reichl <preichl at redhat.com>
>>> Date: Fri, 24 Jul 2015 08:24:48 -0400
>>> Subject: [PATCH 7/9] DYNDNS: remove code duplication
>> ACK
>>
>>>  From ee8d4ef5bdc0b843a8a069bbda58507b4bc9b390 Mon Sep 17 00:00:00 2001
>>> From: Pavel Reichl <preichl at redhat.com>
>>> Date: Fri, 24 Jul 2015 10:41:42 -0400
>>> Subject: [PATCH 8/9] TESTS: UT for sss_iface_addr_list_as_str_list()
>> ACK
>>
>>>  From d49e79e45579b65ed482364be853292343abed9e Mon Sep 17 00:00:00 2001
>>> From: Pavel Reichl <preichl at redhat.com>
>>> Date: Fri, 24 Jul 2015 13:25:56 -0400
>>> Subject: [PATCH 9/9] DYNDNS: improve nsupdate_msg_add_fwd()
>>>
>>> Update nsupdate_msg_add_fwd() to group commands by address family
>>> processed IP address belongs to.
>>>
>>> It's better to group removing old A addresses and adding new A
>>> addresses in a single transaction. Same goes for AAAA addresses.
>>>
>>> Separate transaction for A and AAAA addresses updates are important
>>> because server might block updates for one of these families and thus
>>> the update even for the non-blocked address family would unnecessarily
>>> fail.
>>>
>>> For more details please see:
>>> https://fedorahosted.org/sssd/wiki/DesignDocs/DDNSMessagesUpdate
>>>
>>> Resolves:
>>> https://fedorahosted.org/sssd/ticket/2495
>> Nack, the test doesn't work:
>> ./dyndns-tests
>> [==========] Running 15 test(s).
>> [ RUN      ] dyndns_test_get_ifaddr
>> [       OK ] dyndns_test_get_ifaddr
>> [ RUN      ] dyndns_test_get_multi_ifaddr
>> [       OK ] dyndns_test_get_multi_ifaddr
>> [ RUN      ] dyndns_test_get_ifaddr_enoent
>> [       OK ] dyndns_test_get_ifaddr_enoent
>> [ RUN      ] dyndns_test_addr_list_as_str_list
>> [       OK ] dyndns_test_addr_list_as_str_list
>> [ RUN      ] dyndns_test_ok
>> ldb: unable to dlopen /usr/lib64/ldb/modules/ldb/memberof.la :
>> /usr/lib64/ldb/modules/ldb/memberof.la: invalid ELF header
>> [       OK ] dyndns_test_ok
>> [ RUN      ] dyndns_test_error
>> (Fri Aug 14 16:09:41:326570 2015) [sssd] [child_sig_handler] (0x0020):
>> child [6436] failed with status [1].
>> [       OK ] dyndns_test_error
>> [ RUN      ] dyndns_test_timeout
>> (Fri Aug 14 16:09:43:329799 2015) [sssd] [nsupdate_child_timeout]
>> (0x0020): Timeout reached for dynamic DNS update
>> (Fri Aug 14 16:09:43:330390 2015) [sssd] [child_sig_handler] (0x0020):
>> child [6437] was terminated by signal [9].
>> [       OK ] dyndns_test_timeout
>> [ RUN      ] dyndns_test_interval
>> [       OK ] dyndns_test_interval
>> [ RUN      ] dyndns_test_dualstack
>> [       OK ] dyndns_test_dualstack
>> [ RUN      ] dyndns_test_dualstack_multiple_addresses
>> [       OK ] dyndns_test_dualstack_multiple_addresses
>> [ RUN      ] dyndns_test_dualstack_no_iface
>> [       OK ] dyndns_test_dualstack_no_iface
>> [ RUN      ] dyndns_test_create_fwd_msg
>> Could not run the test - check test fixtures
>> [  ERROR   ] dyndns_test_create_fwd_msg
>> [ RUN      ] dyndns_test_create_fwd_msg_mult
>> Could not run the test - check test fixtures
>> [  ERROR   ] dyndns_test_create_fwd_msg_mult
>> [ RUN      ] dyndns_test_create_fwd_msg_A
>> Could not run the test - check test fixtures
>> [  ERROR   ] dyndns_test_create_fwd_msg_A
>> [ RUN      ] dyndns_test_create_fwd_msg_AAAA
>> Could not run the test - check test fixtures
>> [  ERROR   ] dyndns_test_create_fwd_msg_AAAA
>> [==========] 15 test(s) run.
>> [  PASSED  ] 11 test(s).
>>
>> But I'm going to push the acked patches..
>> _______________________________________________
>> sssd-devel mailing list
>> sssd-devel at lists.fedorahosted.org
>> https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
>
> Test failed because of missing patch  [PATCH 6/9] DYNDNS: use realm and
> server commands only as fallback
>
> I must have skipped it while respinning the patch set, sorry.
>
> I attached this missing patch and test that was failing because of it.

Hi,

>     DYNDNS: use realm and server commands only as fallback
>
>     Resolves:
>     https://fedorahosted.org/sssd/ticket/2195

You have a wrong ticket number here, I think. The patches look good 
otherwise.




More information about the sssd-devel mailing list