[SSSD] [PATCH] IPA: Remove MPG groups if getgrgid was called before getpw()

Lukas Slebodnik lslebodn at redhat.com
Fri Sep 18 08:52:05 UTC 2015


On (14/09/15 11:59), Jakub Hrozek wrote:
>On Fri, Jul 31, 2015 at 10:26:58AM +0200, Jakub Hrozek wrote:
>> On Thu, Jul 30, 2015 at 06:20:31PM +0200, Sumit Bose wrote:
>> > On Wed, Jul 22, 2015 at 12:18:07PM +0200, Jakub Hrozek wrote:
>> > > On Wed, Jul 22, 2015 at 10:01:31AM +0200, Sumit Bose wrote:
>> > > > On Tue, Jul 21, 2015 at 09:41:46PM +0200, Jakub Hrozek wrote:
>> > > > > Hi,
>> > > > > 
>> > > > > the attached patch fixes https://fedorahosted.org/sssd/ticket/2724 for
>> > > > > me. I haven't yet heard back from the affected user, but they do have
>> > > > > test packages available.
>> > > > 
>> > > > The patch is working as expected and fixes the issue for me as well.
>> > > > 
>> > > > Although it might not look as the most elegant way I think the approach
>> > > > is ok because otherwise we would be to check for every group by GID
>> > > > request if the GID might belong to a MPG which would require a user
>> > > > lookup. This would slow down the requests where the GID belong to a
>> > > > normal (non-MPG) group.
>> > > > 
>> > > > Nevertheless I wonder if we should check if the group name matches the
>> > > > user name before deleting the group by GID to be on the safe side?
>> > > 
>> > > OK, done.
>> > 
>> > Thank you. The patch looks good and is working as advertised, ACK.
>> 
>> master: 6fe057efb981ee4b45dcadf131c03f8501fce28d 
>
>I would like to push the patch to sssd-1-12 as well if nobody opposes.
Sure,
go ahead

LS


More information about the sssd-devel mailing list