[SSSD] RFC: Talloc reports

Sumit Bose sbose at redhat.com
Thu Sep 3 11:25:33 UTC 2015


On Thu, Sep 03, 2015 at 12:56:38PM +0200, Jakub Hrozek wrote:
> On Thu, Sep 03, 2015 at 12:48:20PM +0200, Pavel Březina wrote:
> > Hi,
> > due to recent memory leak issues, I think it would be good to provide a
> > built-in way to store talloc full report in a file. It proved to be very
> > helpful in detection of the location where memory leak occurs, but we always
> > obtained it from custom built.
> > 
> > I would very much like to write a patch, but I'd like to hear your opinion
> > on how it should be obtains. I have few ideas:
> > 
> > 1) Periodic task -- periodically (1 hour?) store talloc full report into a
> > file.
> > 
> > 2) Generate report on signal.
> > 
> > 3) Generate report on D-Bus method.
> > 
> > 4) Provide a tool that would do 2) or 3).
> > 
> > I personally favor 1).

I would start with a configurable periodically task as well. An option
like debug_talloc_report_interval which can be use in any section like
debug_level to individually switch it on or off for the different
processes. The default should be 0 which means disabled.

Later on when some general sssctl tool is available we can add a manual
trigger as well.

> 
> Do you plan to use a new debug level to avoid the cost associated with
> walking the talloc hierarchy and printing the output? This debug aid
> must be free of cost for anyone not using it..

Since it is always generated on demand either by configuring a periodic
task or manually I think it will have no extra costs and a new debug
level is not strictly needed.  Nevertheless it should still be easy to
filter those messages.

bye,
Sumit

> _______________________________________________
> sssd-devel mailing list
> sssd-devel at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/sssd-devel


More information about the sssd-devel mailing list