[SSSD] [PATCH] util: Include disabled domains in link_forest_roots

Lukas Slebodnik lslebodn at redhat.com
Fri Oct 30 21:40:21 UTC 2015


On (23/10/15 10:37), Jakub Hrozek wrote:
>On Fri, Oct 23, 2015 at 10:32:38AM +0200, Jakub Hrozek wrote:
>> On Thu, Oct 22, 2015 at 01:00:36PM +0200, Michal Židek wrote:
>> > On 10/22/2015 11:12 AM, Jakub Hrozek wrote:
>> > >On Wed, Oct 21, 2015 at 04:27:36PM +0200, Michal Židek wrote:
>> > >>If you agree that these Coverity complains are false positives
>> > >>it would be good to push the patches. So far they still apply.
>> > >>
>> > >>Michal
>> > >
>> > >The code change we did yesterday silenced the Coverity warning, so if
>> > >you can update the patches also in the autofs responder and re-send I'll
>> > >ACK and push.
>> > 
>> > Thanks Jakub!
>> > 
>> > I added new patch to silence the Coverity warnings.
>> > Other patches are unchanged.
>> > 
>> > Michal
>> > 
>> 
>> ACK to all.
>
>master:
> * e563de9203be581acc30c7794f568ae40d22bee0
> * 2bbc9d6f8d5f2c1b07fd6968314b7f530b7f3a4d
> * f191a6f9f3313df88eaf3debf52eebfe5d3dee59
> * c84dcaa58449c53cf038311ce63bb2c304081b9d
> * 877b92e80bde510d5cd9f03dbf01e2bcf73ab072 
>
>Even though the ticket was originally in 1.13.2, I moved it to 1.14
>alpha and only pushed the patches to master. We can always backport them
>later if we see conflicts, but in general I would prefer to push few
>patches to sssd-1-13..

Michal's patches touched many files.
 src/confdb/confdb.c                          |   2 +-
 src/db/sysdb_subdomains.c                    |  11 +++++-----
 src/monitor/monitor.c                        |  10 ++++-----
 src/providers/ad/ad_subdomains.c             |   4 ++--
 src/providers/dp_refresh.c                   |   2 +-
 src/providers/ipa/ipa_subdomains.c           |   4 ++--
 src/providers/ipa/ipa_subdomains_server.c    |   4 ++--
 src/providers/ldap/sdap_domain.c             |   4 ++--
 src/responder/autofs/autofssrv_cmd.c         |   6 +++---
 src/responder/common/negcache.c              |   8 +++----
 src/responder/common/responder_cache_req.c   |   7 ++++---
 src/responder/common/responder_common.c      |   8 ++++---
 src/responder/common/responder_get_domains.c |   9 ++++----
 src/responder/ifp/ifp_cache.c                |   2 +-
 src/responder/ifp/ifp_domains.c              |   9 ++++----
 src/responder/ifp/ifp_groups.c               |   2 +-
 src/responder/ifp/ifp_users.c                |   2 +-
 src/responder/nss/nsssrv_cmd.c               |  85 +++++++++++++++++++++++++++++++++++++------------------------------------
 src/responder/nss/nsssrv_netgroup.c          |   8 +++----
 src/responder/nss/nsssrv_services.c          |  20 +++++++++---------
 src/responder/pam/pamsrv_cmd.c               |   6 +++---
 src/responder/sudo/sudosrv_get_sudorules.c   |   6 +++---
 src/tests/cmocka/test_utils.c                | 154 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--------
 src/tools/common/sss_tools.c                 |   6 ++++--
 src/tools/sss_cache.c                        |   5 +++--
 src/tools/sss_debuglevel.c                   |   4 ++--
 src/tools/sss_override.c                     |   4 ++--
 src/util/domain_info_utils.c                 |  34 ++++++++++++++++++------------
 src/util/usertools.c                         |   4 ++--
 src/util/util.h                              |   5 ++++-
 30 files changed, 297 insertions(+), 138 deletions(-)

So there was high chance they would cause
conflicts when backporting patches.

And it was required for #2736

sssd-1-13:
* 5b8f64fea67f449c0cb7a62ffb6dc5420141ea5d
* 3dc864a931a8ea9b1fd6b2f37a4773924c3b96b0
* d78a21bb54ff302660a632e23422089b1202ca2c
* 4a3153e8b40b00d6b7aa3f54589d1527e9e138c9
* 2a385185e0c57bebda38b769579a012c6d38eb23

LS


More information about the sssd-devel mailing list