[SSSD] [PATCH] sss_override: add -find and -show

Pavel Březina pbrezina at redhat.com
Thu Oct 29 14:17:23 UTC 2015


On 10/26/2015 01:57 PM, Pavel Reichl wrote:
> Thanks, patch set works for me now.
>
> I have just a few last nitpicks.
>
> user-find takes extra parameter but ignores it, I believe this is not
> user friendly as IMO user will consider it to be a domain name.
>
> Please consider expanding man page description for --domain option in
> commands user-find and group-find.
>
>> +static int override_group_show(struct sss_cmdline *cmdline,
>> +                               struct sss_tool_ctx *tool_ctx,
>> +                               void *pvt)
>> +{
>> +    TALLOC_CTX *tmp_ctx;
>> +    struct override_group input = {NULL};
>> +    const char *dn;
>> +    char *anchor;
>> +    const char *filter;
>> +    int ret;
>
> Please add empty line here.
>
>> +    tmp_ctx = talloc_new(NULL);
>> +    if (tmp_ctx == NULL) {
>> +        DEBUG(SSSDBG_CRIT_FAILURE, "talloc_new() failed.\n");
>> +        return EXIT_FAILURE;
>> +    }
>> +
>> +    ret = parse_cmdline_group_show(cmdline, tool_ctx, &input);
>> +   if (ret != EOK) {
>
> Indentation.
>
>> +        DEBUG(SSSDBG_CRIT_FAILURE, "Unable to parse command line.\n");
>> +        goto done;
>> +    }
>> +
>> +    ret = get_group_domain_msg(tool_ctx, &input);
>> +    if (ret != EOK) {
>> +        DEBUG(SSSDBG_CRIT_FAILURE, "Unable to get object domain\n");
>> +        goto done;
>> +    }
>> +
>> +    ret = get_object_dn(tmp_ctx, input.domain, SYSDB_MEMBER_GROUP,
>> +                       input.orig_name, NULL, &dn);
> Indentation.
>> +    if (ret != EOK) {
>> +        DEBUG(SSSDBG_CRIT_FAILURE, "Unable to get object dn\n");
>> +        goto done;
>> +    }

Here you go.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-sss_tools-always-show-common-and-help-options.patch
Type: text/x-patch
Size: 1697 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20151029/0ae61c9d/attachment-0009.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-sss_override-fix-exporting-multiple-domains.patch
Type: text/x-patch
Size: 1451 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20151029/0ae61c9d/attachment-0010.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-sss_override-add-user-find.patch
Type: text/x-patch
Size: 9391 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20151029/0ae61c9d/attachment-0011.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-sss_override-add-group-find.patch
Type: text/x-patch
Size: 7443 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20151029/0ae61c9d/attachment-0012.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-sss_override-add-user-show.patch
Type: text/x-patch
Size: 8274 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20151029/0ae61c9d/attachment-0013.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-sss_override-add-group-show.patch
Type: text/x-patch
Size: 6776 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20151029/0ae61c9d/attachment-0014.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0007-sss_override-do-not-free-ldb_dn-in-get_object_dn.patch
Type: text/x-patch
Size: 2404 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20151029/0ae61c9d/attachment-0015.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0008-sss_override-use-more-generic-help-text.patch
Type: text/x-patch
Size: 1107 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20151029/0ae61c9d/attachment-0016.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0009-sss_tools-do-not-allow-unexpected-free-argument.patch
Type: text/x-patch
Size: 1732 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20151029/0ae61c9d/attachment-0017.bin>


More information about the sssd-devel mailing list