[SSSD] [PATCH] TEST: recent_valid filter testing

Petr Cech pcech at redhat.com
Tue Oct 27 08:42:20 UTC 2015


On 10/23/2015 12:57 PM, Jakub Hrozek wrote:
> Thank you, I think your approach is correct. Your test essentially tests
> that testuser2 was on the server but was removed, so only testuser1 is
> returned.
>
> It's correct, but because the interface is able to return more users, I
> would prefer if we tested that as well.
>
> I have one more minor remark inline, but in general, please go
> ahead and add back the other tests..

Hello Jakub and everyone!

The first patch set is attached.

The removed tests were:
  * users_by_filter_valid
  * users_by_filter_multiple_domains_valid
  * groups_by_filter_valid
  * groups_by_filter_multiple_domains_valid

This patch set covers users_by_filter_valid by two new tests:
  * user_by_recent_filter_valid
  * users_by_recent_filter_valid

The first of them tests the recent filter. The seconds tests interface 
ability to return more users.

Regards,

Petr
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-TEST-Add-test_user_by_recent_filter_valid.patch
Type: text/x-patch
Size: 4094 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20151027/57978d69/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-TEST-Refactor-of-test_responder_cache_req.c.patch
Type: text/x-patch
Size: 5892 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20151027/57978d69/attachment-0004.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-TEST-Add-test_users_by_recent_filter_valid.patch
Type: text/x-patch
Size: 4483 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20151027/57978d69/attachment-0005.bin>


More information about the sssd-devel mailing list