[SSSD] [PATCH] SDAP: rem warning - sizelimit exceeded in POSIX check

Sumit Bose sbose at redhat.com
Tue Oct 20 13:54:51 UTC 2015


On Mon, Oct 19, 2015 at 06:49:21PM +0200, Pavel Reichl wrote:
> 
> 
> On 10/19/2015 05:56 PM, Sumit Bose wrote:
> >On Mon, Oct 19, 2015 at 05:01:50PM +0200, Pavel Reichl wrote:
> >
> [snip]
> >>
> >>We also set allow_paging = true if some controls are to be used without checking the scope. I added warning for that case (please let me know if it's useless).
> >
> >I'm afraid they are. The deref/asq controls typically have the based
> >scope (iirc for asq it is even required).
> >
> 
> Fixed, thanks.
> [snip]
> >>
> >>Would it make sense to add warnings as I proposed in patch 4?
> >
> >oh. Sorry, I didn't checked the current code more carefully before. It
> >does not make sense to call sdap_get_generic_ext_send() from
> >sdap_get_and_parse_generic_send() with dropping attrsonly, serverctrls
> >and clientctrls. Please instead of writing a warning just pass them down
> >to sdap_get_generic_ext_send().
> >
> No problem, I should have been able to describe the problem without need to look into code.
> 
> [snip]
> >>              /* Try to return what we've got */
> >>-            DEBUG(SSSDBG_MINOR_FAILURE,
> >>-                  "LDAP sizelimit was exceeded, returning incomplete data\n");
> >>+
> >>+            bool sizelimit_silent =
> >>+                state->flags & SDAP_SRCH_FLG_SIZELIMIT_SILENT;
> >>+
> >>+            if (sizelimit_silent == false) {
> >
> >I think there is no need for an extra variable and
> >
> >            if ( ! (state->flags & SDAP_SRCH_FLG_SIZELIMIT_SILENT)) {
> >
> >is imo quite readable as well.
> >
> OK, fixed.
> 
> Please see updated attached patch set.

Thank you, I do not have any further comments and the patches pass CI as
well http://sssd-ci.duckdns.org/logs/job/30/83/summary.html, so ACK.

Please note that the 1st patch only supress the "LDAP sizelimit was
exceeded, returning incomplete data" at debug level
SSSDBG_MINOR_FAILURE. But the general mesages about return code at level
SSSDBG_TRACE_FUNC will be still available:

(Tue Oct 20 13:49:51 2015) [sssd[be[ad.devel]]] [sdap_get_generic_op_finished] (0x0400): Search result: Size limit exceeded(4), no errmsg set

bye,
Sumit


More information about the sssd-devel mailing list