[SSSD] [PATCHES][IPA][RFE] Implement iCal based time managment in HBAC

Lukas Slebodnik lslebodn at redhat.com
Thu Oct 15 07:50:03 UTC 2015


On (14/10/15 15:02), Jakub Hrozek wrote:
>On Wed, Oct 07, 2015 at 10:20:03AM +0200, Stanislav Laznicka wrote:
>> From 0a40a390afe56ec27c070ed743ba6f3d39b564aa Mon Sep 17 00:00:00 2001
>> From: Stanislav Laznicka <slaznick at redhat.com>
>> Date: Mon, 13 Jul 2015 10:00:42 +0200
>> Subject: [PATCH 2/6] IPA: Added evaluation of time policies in HBAC
>> 
>> The time policies in FreeIPA HBAC objects are now evaluated in
>> the libipa_hbac module.
>> 
>> TODO: Had to disable the pyhbac tests until proper python
>> bindings are implemented.
>> 
>> https://fedorahosted.org/freeipa/ticket/547
>
>It would be better to include the SSSD ticket in the commit message.
>
>It would also be nice to add a link to the design page into the commit
>message.
>
>You added new functions to the API, so the version info of libipa_hbac
>must be incremented:
>    https://www.gnu.org/software/libtool/manual/libtool.html#Updating-version-info
It's recomended to bump version-info once in a release.
And we already did it for libhbac with changes in logging.

>and the src/providers/ipa/ipa_hbac.exports must be amended as well.
>
Yes it should be, otherwise it could not be used by other programs.
because new function would not be visible. Or maybe they needn't be visible
in public interface. (I didn't check changes in public header files)

LS


More information about the sssd-devel mailing list