[SSSD] [PATCH v2] intg: Add more LDAP tests

Nikolai Kondrashov Nikolai.Kondrashov at redhat.com
Wed Oct 7 17:51:24 UTC 2015


On 09/30/2015 06:15 PM, Nikolai Kondrashov wrote:
> Hi everyone,
>
> Here is a patch set fixing some things in integration tests and adding more
> LDAP tests:
>
>      * Adding/removing a user/group/membership with rfc2307(bis) schema.
>      * Filtering users/groups with rfc2307(bis) schema.
>      * The effect of override_homedir option.
>      * The effect of fallback_homedir option.
>      * The effect of override_shell option.
>      * The effect of shell_fallback option.
>      * The effect of default_shell option.
>      * The effect of vetoed_shells option.
>
> These are pretty basic, but I think they're good for the start.
> Suggestions for more tests are welcome :)
>
> NOTE: These still break test_memory_cache.py as seen in the attached log file.
>        We need to figure out why and do something with it. Otherwise, the
>        tests work fine.

Here's another version of the patch set. It's not complete, but takes some
comments into account. Namely:

     * Explicitly name the new arguments for ldap_ent.user and
       ldap_ent.List.add_user, instead of using "kwargs". Add "gecos" too. This
       makes the function more suitable for Pavel Reichl's needs.
     * Don't remove "_rfc2307" from function names anywhere.
     * Use a string "schema" argument with configuration formatting functions
       instead of boolean "bis" argument to support other schemas. Use
       constants to specify the values in invocations.
     * Explicitly specify "enum" argument name when invoking configuration
       formatting functions.
     * Remove duplicate "blank" fixture function.

I'll continue working on the patch set. Namely adding tests without
enumeration, looking for and fixing the memory cache test failures induced by
the new tests, trying to move commonly used fixtures and other functions to a
module so we don't copy them.

Nick
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-intg-Get-base-DN-from-LDAP-connection-object.patch
Type: text/x-patch
Size: 2690 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20151007/950674d4/attachment-0006.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-intg-Add-support-for-specifying-all-user-attrs.patch
Type: text/x-patch
Size: 3492 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20151007/950674d4/attachment-0007.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-intg-Split-LDAP-test-fixtures-for-flexibility.patch
Type: text/x-patch
Size: 5092 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20151007/950674d4/attachment-0008.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-intg-Reduce-sssd.conf-duplication-in-test_ldap.py.patch
Type: text/x-patch
Size: 6600 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20151007/950674d4/attachment-0009.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-intg-Fix-RFC2307bis-group-member-creation.patch
Type: text/x-patch
Size: 1599 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20151007/950674d4/attachment-0010.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-intg-Add-more-LDAP-tests.patch
Type: text/x-patch
Size: 22161 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20151007/950674d4/attachment-0011.bin>


More information about the sssd-devel mailing list