[SSSD] [PATCH] intg: Add more LDAP tests

Nikolai Kondrashov Nikolai.Kondrashov at redhat.com
Wed Oct 7 14:09:28 UTC 2015


On 10/07/2015 10:51 AM, Lukas Slebodnik wrote:
> On (06/10/15 11:27), Jakub Hrozek wrote:
>> On Wed, Sep 30, 2015 at 06:15:52PM +0300, Nikolai Kondrashov wrote:
>>> Remove "_rfc2307" from integration test function names for brevity.
>
> Please do not remove sanity_rfc2307 from this test.
> It was added intentionaly. So it's clear from the name of fixture
> which ldap schema is used.
>
> If you want to remove it from ldap_test.py feel free to do it
> but please do not chage it in test_memory_cache.py

Sure, no problem. Moreover, based on conversation with Jakub, I think I'll
need to keep them everywhere, one way or another.

> BTW: there are introduced new pep8 warning by your patches:
>
> 0007-intg-Add-more-LDAP-tests.patch
> In attachement :-)
>
> Some of warnings neen't be caught by pep8 --diff (blank lines after function ..

Right, I forgot to run it again. Thank you for checking.

> And now back to failing test memory cache.
> It works for me if I change the order of tests (mv ldap_test_.py test_xldap.py)
> So your test had to introduce an issue in last patch.

Yeah, my tests are obviously interfering with your tests. I hoped you might
suggest the reason, since you know them and SSSD better, but I can dig it
myself.

> It also constantly fails for me; so it can be related.
> ================================================ FAILURES ================================================
> __________________________________________ test_add_remove_user __________________________________________

Now, this is interesting. Is this the only test that fails? If not, which
tests fail? Is the failure pattern constant? Which environment were you
running them in? Was it my unchanged patch set, or was that after you switched
the order?

Thank you.

Nick


More information about the sssd-devel mailing list