[SSSD] CI: Already fixed bug for TODO

Lukas Slebodnik lslebodn at redhat.com
Thu Oct 1 06:44:59 UTC 2015


On (30/09/15 17:39), Nikolai Kondrashov wrote:
>On 09/30/2015 08:20 AM, Lukas Slebodnik wrote:
>>On (29/09/15 17:35), Nikolai Kondrashov wrote:
>>>On 09/29/2015 05:13 PM, Nikolai Kondrashov wrote:
>>>>On 09/29/2015 03:54 PM, Lukas Slebodnik wrote:
>>>>>ehlo,
>>>>>
>>>>>I touched the CI script and I found an interesting todo
>>>>>
>>>>>distro.sh-52-{
>>>>>distro.sh-53-    declare prompt=$'Need root permissions to install packages.\n'
>>>>>distro.sh-54-    prompt+="Enter sudo password for $USER: "
>>>>>distro.sh-55-    if [[ "$DISTRO_BRANCH" == -redhat-* ]]; then
>>>>>distro.sh-56-        [ $# != 0 ] && sudo -p "$prompt" yum --assumeyes install -- "$@" |&
>>>>>distro.sh-57-            # Pass input to output, fail if a missing package is reported
>>>>>distro.sh-58-            # TODO Remove and switch to DNF once
>>>>>distro.sh:59:            # https://bugzilla.redhat.com/show_bug.cgi?id=1128139 is fixed
>>>>>distro.sh-60-            awk 'BEGIN {s=0}
>>>>>distro.sh-61-                 /^No package .* available.$/ {s=1}
>>>>>distro.sh-62-                 {print}
>>>>>distro.sh-63-                 END {exit s}'
>>>>>distro.sh-64-    elif [[ "$DISTRO_BRANCH" == -debian-* ]]; then
>>>>>distro.sh-65-        [ $# != 0 ] && sudo -p "$prompt" apt-get --yes install -- "$@"
>>>>>distro.sh-66-    else
>>>>>
>>>>>
>>>>>The BZ1128139 was closed as duplicate of BZ1107737.
>>>>>The BZ1107737 was fixed 7 months ago and is available in
>>>>>dnf >= 0.6.4-2. The Fedora 21 currently have dnf-0.6.4-7.
>>>>>I think it's the best time for removing this todo.
>>>>
>>>>I would very much like to get rid of it, but unfortunately we're blocked by
>>>>this DNF bug here:
>>>>
>>>>     https://bugzilla.redhat.com/show_bug.cgi?id=1215208
>>>>
>>>>Due to this bug we still have to use yum-deprecated on Fedora Rawhide (by
>>>>modifying /usr/bin/yum to invoke yum-deprecated instead of dnf) and the bug
>>>>mentioned in the TODO wasn't and likely won't be fixed in yum.
>>>
>>>So, I think we can only update the bug number for now. The patch is attached.
>>>
>>>Nick
>>
>>Would you mind open upstream tracking ticket rather then changing
>>number of BZ? We have Continuous integration bucket.
>
>I opened the ticket: https://fedorahosted.org/sssd/ticket/2809
>
>However, I think it's better to also update the source, so the next person
>reading it doesn't have the same question and/or tries to switch to DNF only
>to find another problem, the one described in the bug I mention.
>
Make sense.

ACK to the patch

>>It's fine there is a plan how to fix BZ1215208 but it would be also good to
>>know what is an ETA (at least approximately :-)
>
>I asked one of the DNF developers in a comment to the DNF bug. Let's see if we
>get any answer.
>
thank you.

LS


More information about the sssd-devel mailing list