[SSSD] [PATCH] test_sysdb_subdomains: Do use assignment in assertions

Jakub Hrozek jhrozek at redhat.com
Sat Nov 14 12:32:33 UTC 2015


On Fri, Nov 13, 2015 at 11:57:59AM +0100, Lukas Slebodnik wrote:
> On (13/11/15 11:12), Jakub Hrozek wrote:
> >On Fri, Nov 13, 2015 at 08:51:17AM +0100, Lukas Slebodnik wrote:
> >> ehlo,
> >> 
> >> I found these iisues due to different size of integer and pointer
> >> on el6.
> >> 
> >> /home/build/sssd/src/tests/cmocka/test_sysdb_subdomains.c:248: error: cast from
> >> pointer to integer of different size
> >> 
> >> Simple patch is attached.
> >> 
> >> LS
> >
> >Code-wise ACK, waiting for CI results. But I think the commit message is
> >incorrect, I would like to reword it to "Don't use.." before pushing.
>                                           ^^^^^^^^^^^
>                                           of course.
>                                         I'm sorry for the mistake
> 

Since the CI is stuck, I pushed the patches to master:
    * 06d4c022874d4f12d70e79c3c749d52fe020dad6
and sssd-1-13:
    * 782ea07cd614a381f40af46de3e54eabc9657dce


More information about the sssd-devel mailing list