[SSSD] [PATCH] FAIL_OVER: Fix warning value computed is not used

Pavel Reichl preichl at redhat.com
Tue Nov 10 13:55:43 UTC 2015



On 11/10/2015 02:39 PM, Jakub Hrozek wrote:
> On Tue, Nov 10, 2015 at 09:11:25AM +0100, Lukas Slebodnik wrote:
>> ehlo,
>>
>> another warning on rhel6.
>
> ACK
>
>>
>> BTW different solution would be to cast to void.
>
> I prefer this solution

Why? I think that changing value of input parameter is generally a discouraged practice, although in our code base it's common. (I'm just asking I'm *not* nacking the patch.)

>
> CI: http://sssd-ci.duckdns.org/logs/job/32/38/summary.html
>
> (Fedora-20 failure is unrelated)
> _______________________________________________
> sssd-devel mailing list
> sssd-devel at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
>


More information about the sssd-devel mailing list