[SSSD] [PATCH] tools: Don't shadow 'exit'

Jakub Hrozek jhrozek at redhat.com
Mon Nov 9 14:15:43 UTC 2015


On Mon, Nov 09, 2015 at 12:05:34PM +0100, Lukas Slebodnik wrote:
> On (09/11/15 10:30), Jakub Hrozek wrote:
> >Hi,
> >
> >please see the attached trivial patch.
> 
> >From a27bf8f594bbbba372a4c324b00b7931306b774c Mon Sep 17 00:00:00 2001
> >From: Jakub Hrozek <jhrozek at redhat.com>
> >Date: Mon, 9 Nov 2015 10:27:41 +0100
> >Subject: [PATCH] tools: Don't shadow 'exit'
> >MIME-Version: 1.0
> >Content-Type: text/plain; charset=UTF-8
> >Content-Transfer-Encoding: 8bit
> >
> >Fixes:
> >    /sssd/src/tools/sss_override.c: In function ‘override_user_import’:
> >    /sssd/src/tools/sss_override.c:1471: warning: declaration of ‘exit’ shadows a global declaration
> >    /usr/include/stdlib.h:544: warning: shadowed declaration is here
> >    /sssd/src/tools/sss_override.c: In function ‘override_group_import’:
> >    /sssd/src/tools/sss_override.c:1737: warning: declaration of ‘exit’ shadows a global declaration
> >    /usr/include/stdlib.h:544: warning: shadowed declaration is here
> I found few others similar warnings.
> Do we want to fix them or ignore?
> 
> I can see then only on centos 6 which has old gcc.

That's how I found the first one, I was debugging sssd patches on RHEL-6
:-)

> 
> See few patches. I might squash them

I will ack yours in exchange of your review of my patch.


More information about the sssd-devel mailing list