[SSSD] [PATCH] CI: Enforce coverage make check failures

Lukas Slebodnik lslebodn at redhat.com
Mon Nov 9 13:43:12 UTC 2015


On (09/11/15 14:41), Lukas Slebodnik wrote:
>On (07/10/15 08:15), Lukas Slebodnik wrote:
>>On (23/06/15 17:01), Lukas Slebodnik wrote:
>>>On (17/06/15 16:26), Nikolai Kondrashov wrote:
>>>>Hi everyone,
>>>>
>>>>The attached patch enforces make check failures for the CI coverage build, so
>>>>we can catch more test failures.
>>>>
>>>>I think this should also be applied onto sssd-1-12.
>>>>
>>>>NOTE: CI won't pass with this patch ATM, as test_ipa_subdom_server needs to be
>>>>      fixed first.
>>>>
>>>>Nick
>>>
>>>>From 14485fbe72ab4c5acaea30899b1dc5bd652e4d36 Mon Sep 17 00:00:00 2001
>>>>From: Nikolai Kondrashov <Nikolai.Kondrashov at redhat.com>
>>>>Date: Wed, 17 Jun 2015 15:13:41 +0300
>>>>Subject: [PATCH] CI: Enforce coverage make check failures
>>>>
>>>>Fail CI coverage build, if make-check stage fails. Previously make-check
>>>>stage failures were ignored for coverage build for the sake of
>>>>collecting coverage data in any case. However, catching extra test
>>>>failures seems more important than getting coverage data in all cases,
>>>>thus the change.
>>>>---
>>>> contrib/ci/run | 5 ++++-
>>>> 1 file changed, 4 insertions(+), 1 deletion(-)
>>>>
>>>>diff --git a/contrib/ci/run b/contrib/ci/run
>>>>index 5f668ff..e22ed41 100755
>>>>--- a/contrib/ci/run
>>>>+++ b/contrib/ci/run
>>>>@@ -255,6 +255,7 @@ function build_coverage()
>>>> {
>>>>     declare -r coverage_report_dir="ci-report-coverage"
>>>>     declare test_dir
>>>>+    declare status
>>>> 
>>>>     export CFLAGS="$COVERAGE_CFLAGS"
>>>> 
>>>>@@ -271,8 +272,10 @@ function build_coverage()
>>>>                                  --base-directory "$BASE_DIR" \
>>>>                                  --output-file ci-base.info
>>>>     # Run tests
>>>>-    stage make-check        make -j $CPU_NUM check || true
>>>>+    status=$?
>>>>+    stage make-check        make -j $CPU_NUM check || status=$?
>>>>     mv "$test_dir" ci-test-dir
>>>>+    ((status == 0))
>>>> 
>>>>     stage lcov-post         lcov --capture --directory . \
>>>>                                  --base-directory "$BASE_DIR" \
>>>>-- 
>>>>2.1.4
>>>>
>>>Just for record.
>>>The patch works but need to fix failed test on rhel6.
>>>
>>Nobody have tried to fix it for some time.
>>Therefore I filed a ticket.
>>https://fedorahosted.org/sssd/ticket/2819
>>
>Blocer ticket was resolved.
>So we can finally push the patch.
>
>http://sssd-ci.duckdns.org/logs/job/32/23/summary.html
>
>ACK
>

master:
* 8d1b572126afceb60693ff4c4a734bd6dbdaf548

sssd-1-13:
* d15c3b2207c32cce6e1c49acfbe3014e34455017

LS


More information about the sssd-devel mailing list