[SSSD] [PATCH] TESTS: fix segfault in test_sss_strerror_err_last

Lukas Slebodnik lslebodn at redhat.com
Thu May 28 15:45:56 UTC 2015


On (28/05/15 17:25), Pavel Reichl wrote:
>Hello,
>
>please see simple attached patch. Although test catches the bug and is no
>doubt useful I believe that we should avoid segfaulting even in tests.
>
>Thanks for considering!

>From a509c49fbc55664170d96e0e29bf6263c8d38a2a Mon Sep 17 00:00:00 2001
>From: Pavel Reichl <preichl at redhat.com>
>Date: Thu, 28 May 2015 11:13:47 -0400
>Subject: [PATCH] TESTS: fix segfault in test_sss_strerror_err_last
>
>If there were more error codes than error messages. This
>test segfaulted.
>
When test crashed then it failed.
So the problem was not in test but in sssd code.

IMHO it's sufficient to test that the last error code is the same.

LS



More information about the sssd-devel mailing list